Giter VIP home page Giter VIP logo

Comments (1)

wodCZ avatar wodCZ commented on June 11, 2024

Currently this implementation saves the entire cache as a single value

Actually, that depends on the serialize option. With serialize: false and compatible driver (only LocalForage as of now I believe), JSON is not called.

whenever checking the cache

That definitely is one of the most expensive bits this library performs, but:

  • parsing is only done when calling restore, usually only once, during application bootstraping
  • serialization is only done when persisting, depending on your trigger setting. This doesn't perform read nor parse.

So, there is a space for optimization, especially looking at trigger: 'write', serialize: 'true' combo with a slow storage driver could be wasteful.

But, I think the library provides enough means for building more performant storage wrappers. Personally I haven't found a need for such wrapper, but I'm happy to review any take towards this cause.

Given that the maintainer team (of this community library) is currently very limited, I'll say in advance that if we were to merge more complex storage wrapper, or any mechanism, I'd first want to see any kind of benchmark implemented, so we can actually verify that the added value is worth the extra support we'll have to dedicate to the new feature.

from apollo-cache-persist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.