Comments (6)
Hello @Tainan404 - nice catch!
I would like to add that consistently deduplicating the subscriptions is a very important feature for BigBlueButton.
This feature allowed us to decouple the data consumption, allowing each component to require the data of interest.
However, with this bug, we will eventually get duplicated subscriptions, increasing the load in both client and server.
@jerelmiller - we have some workarounds in mind, like creating a hook named useDeduplicatedSubscription
, but if it's something you could fix on apollo-client, it would benefit the whole comunity of users.
Any feedback in this issue will be highly appreciated.
Thank you!
from apollo-client.
Hi @Tainan404 and @TiagoJacobs 👋
I see that the relevant feature request apollographql/apollo-feature-requests#74 was closed by #6910.
As you described, I am seeing deduplication of the initial subscriptions, but when subsequent components are rendered as you said I'm seeing new connections open. I suspect I know what's happening here: any existing deduplication is happening in the QueryManager when startGraphQLSubscription
calls getObservableFromLink
, so requests that are fired in quick succession can be deduped, but we don't keep track of subscriptions with e.g. a unique cache key, so if the same subscription is being opened at a later time, it cannot be deduplicated against all currently running subscriptions.
I'll have to dig into this more and discuss with the team, thanks for the reproduction!
from apollo-client.
Hello @alessbell,
To temporarily address this issue, we have implemented a new hook in BigBlueButton called usedDeduplicatedSubscription
. You can find the pull request here.
I am sending it here in case it can be helpful to others.
PS: Looking forward for an oficial fix in the future.
Thanks again!
from apollo-client.
Maybe same like this here? #10117
from apollo-client.
Hello @dominikklein - yes, it's the same case!
from apollo-client.
When this would work in a better way, would it be the same for subscribeToMore
or is this currently in general handled in a different way?
from apollo-client.
Related Issues (20)
- React 19 has updated this SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED HOT 2
- [Data masking] Mask named fragments from data returned from `watchFragment` and `useFragment` HOT 2
- [Data masking] Mask named fragment data returned from mutations HOT 2
- [Data masking] Mask named fragments for data returned from subscriptions HOT 2
- [Data masking] Mask named fragments from data returned in `cache.readQuery` HOT 2
- [Data masking] Mask named fragments for data returned in `cache.readFragment` HOT 2
- [Data masking] Ensure data masking can lookup fragments from the fragment registry HOT 2
- Why does cache read and write operation takes a lot of time when we define client-side variable to a fragment? HOT 3
- [Data masking] Ensure data masking properly handles `null` as top-level, array item, or field with child selection set HOT 2
- [Data masking] Ensure data masking works with `@defer` payloads
- [Data masking] Provide solution for TypeScript type compatibility for APIs that use both the masked result and full result
- [Data masking] Warning for field in migrate mode is overagressive
- Websockets can't connect through reverse proxy HOT 2
- useQuery polling query does not stop issuing network requests when the skip argument switches from false to true HOT 3
- `useFragment` does not re-render as expected in v3.11.5 HOT 4
- UseFragment producing a warning during store misses (TypeError: Cannot read properties of undefined) HOT 6
- Cannot read properties of undefined (reading 'data') HOT 13
- Still no alternative to onCompleted change in 3.8 HOT 5
- useSuspenseQuery with skipToken still requires an apolloClient HOT 7
- skip: true and skipToken behave differently with useSuspenseQuery HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apollo-client.