Comments (5)
calvincestari
commented on September 24, 2024
@Iron-Ham, did you have any luck working with the schema we spoke about last week to reproduce this yet?
from apollo-ios.
Iron-Ham
commented on September 24, 2024
So that this isn't a black-box for other impacted folks: Calvin and I have been sharing information via private channels in order to try and track down this issue.
It proved quite difficult to reproduce outside of GitHub's non-public schema, so we've been collaborating on trying down to narrow down a reproduction case. Earlier this week, Calvin shared an idea and provided a branch that includes additional debugging when it hits a duplicate. The basis is that Calvin has the hypothesis we'd like to test: given that mergedSources is an OrderedSet<IR.MergedSelections.MergedSource> it's possible that we're not getting exact duplicates – the typeInfo or fragment sources may be different, and they could be resolved to the same selection set name. This implies that we may not be resolving the selection set name correctly.
When applying that branch to a fork of 1.7.1 (as that's the current version we are using internally at GitHub), we hit some debugging logs that seem to support the general hypothesis:
1.7.1 Logs
[ERROR - ApolloCodegenLib:SelectionSetTemplate.swift:182] - 4 mergedSources for operation(IR.Operation)
Sources: OrderedSet<MergedSource>([[[Object - User]], fragment: UserListItemFragment on Object - User, [[Interface - Actor]], fragment: AvatarFragment on Interface - Actor, [[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem, [[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem])
Duplicating generated selection set name FeedItemFragment.AsFollowRecommendationFeedItem.Followee.AsUser
[ERROR - ApolloCodegenLib:SelectionSetTemplate.swift:182] - 4 mergedSources for operation(IR.Operation)
Sources: OrderedSet<MergedSource>([[[Object - User]], fragment: UserListItemFragment on Object - User, [[Interface - Actor]], fragment: AvatarFragment on Interface - Actor, [[Union - FeedItem -> Object - FollowedUserFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem, [[Union - FeedItem -> Object - FollowedUserFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem])
Duplicating generated selection set name FeedItemFragment.AsFollowedUserFeedItem.Followee.AsUser
[ERROR - ApolloCodegenLib:SelectionSetTemplate.swift:182] - 4 mergedSources for operation(IR.Operation)
Sources: OrderedSet<MergedSource>([[[Object - User]], fragment: UserListItemFragment on Object - User, [[Interface - Actor]], fragment: AvatarFragment on Interface - Actor, [[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem, [[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem])
Duplicating generated selection set name FeedItemFragment.AsFollowRecommendationFeedItem.Followee.AsUser
[ERROR - ApolloCodegenLib:SelectionSetTemplate.swift:182] - 4 mergedSources for operation(IR.Operation)
Sources: OrderedSet<MergedSource>([[[Object - User]], fragment: UserListItemFragment on Object - User, [[Interface - Actor]], fragment: AvatarFragment on Interface - Actor, [[Union - FeedItem -> Object - FollowedUserFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem, [[Union - FeedItem -> Object - FollowedUserFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem])
Duplicating generated selection set name FeedItemFragment.AsFollowedUserFeedItem.Followee.AsUser
Examining the first error statement, and adding some new lines where I think they belong (please correct me on this one if my assumptions are wrong @calvincestari), we're left with:
[ERROR - ApolloCodegenLib:SelectionSetTemplate.swift:182] - 4 mergedSources for operation(IR.Operation)
Sources: OrderedSet<MergedSource>([
[[Object - User]], fragment: UserListItemFragment on Object - User,
[[Interface - Actor]], fragment: AvatarFragment on Interface - Actor,
[[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem,
[[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem
])
Duplicating generated selection set name FeedItemFragment.AsFollowedUserFeedItem.Followee.AsUser
When applied to the ApolloCodegenLib's main branch – instead of 1.7.1 – we see an identical result:
1.8.x Logs
[ERROR - ApolloCodegenLib:SelectionSetTemplate.swift:182] - 4 mergedSources for operation(IR.Operation)
Sources: OrderedSet<MergedSource>([[[Object - User]], fragment: UserListItemFragment on Object - User, [[Interface - Actor]], fragment: AvatarFragment on Interface - Actor, [[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem, [[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem])
Duplicating generated selection set name FeedItemFragment.AsFollowRecommendationFeedItem.Followee.AsUser
[ERROR - ApolloCodegenLib:SelectionSetTemplate.swift:182] - 4 mergedSources for operation(IR.Operation)
Sources: OrderedSet<MergedSource>([[[Object - User]], fragment: UserListItemFragment on Object - User, [[Interface - Actor]], fragment: AvatarFragment on Interface - Actor, [[Union - FeedItem -> Object - FollowedUserFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem, [[Union - FeedItem -> Object - FollowedUserFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem])
Duplicating generated selection set name FeedItemFragment.AsFollowedUserFeedItem.Followee.AsUser
[ERROR - ApolloCodegenLib:SelectionSetTemplate.swift:182] - 4 mergedSources for operation(IR.Operation)
Sources: OrderedSet<MergedSource>([[[Object - User]], fragment: UserListItemFragment on Object - User, [[Interface - Actor]], fragment: AvatarFragment on Interface - Actor, [[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem, [[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem])
Duplicating generated selection set name FeedItemFragment.AsFollowRecommendationFeedItem.Followee.AsUser
[ERROR - ApolloCodegenLib:SelectionSetTemplate.swift:182] - 4 mergedSources for operation(IR.Operation)
Sources: OrderedSet<MergedSource>([[[Object - User]], fragment: UserListItemFragment on Object - User, [[Interface - Actor]], fragment: AvatarFragment on Interface - Actor, [[Union - FeedItem -> Object - FollowedUserFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem, [[Union - FeedItem -> Object - FollowedUserFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem])
Duplicating generated selection set name FeedItemFragment.AsFollowedUserFeedItem.Followee.AsUser
Adding newlines to the first output, as before, yields:
[ERROR - ApolloCodegenLib:SelectionSetTemplate.swift:182] - 4 mergedSources for operation(IR.Operation)
Sources: OrderedSet<MergedSource>([
[[Object - User]], fragment: UserListItemFragment on Object - User,
[[Interface - Actor]], fragment: AvatarFragment on Interface - Actor,
[[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem,
[[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem
])
Duplicating generated selection set name FeedItemFragment.AsFollowRecommendationFeedItem.Followee.AsUser
from apollo-ios.
calvincestari
commented on September 24, 2024
Thanks @Iron-Ham.
[ERROR - ApolloCodegenLib:SelectionSetTemplate.swift:182] - 4 mergedSources for operation(IR.Operation)
Sources: OrderedSet<MergedSource>([
[[Object - User]], fragment: UserListItemFragment on Object - User,
[[Interface - Actor]], fragment: AvatarFragment on Interface - Actor,
[[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem,
[[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]], fragment: FeedItemFragment on Union - FeedItem
])
Duplicating generated selection set name FeedItemFragment.AsFollowRecommendationFeedItem.Followee.AsUser
Yup, you've broken it up correctly and it looks like we are indeed getting duplicates in the set - which should not be happening!
from apollo-ios.
Iron-Ham
commented on September 24, 2024
When ran again with additional debugging, we get the following:
Logs
Cleaned first result:
[ERROR - ApolloCodegenLib:SelectionSetTemplate.swift:182] - 4 mergedSources for operation(IR.Operation)
Sources: [
entity: IR.Entity,
scopePath: [[Object - User]],
fragment:
rootField: UserListItemFragment: User!,
definition: UserListItemFragment on Object - User,
entity: IR.Entity,
scopePath: [[Interface - Actor]],
fragment:
rootField: AvatarFragment: Actor!,
definition: AvatarFragment on Interface - Actor,
entity: IR.Entity,
scopePath: [[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]],
fragment:
rootField: FeedItemFragment: FeedItem!,
definition: FeedItemFragment on Union - FeedItem,
entity: IR.Entity,
scopePath: [[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]],
fragment:
rootField: FeedItemFragment: FeedItem!,
definition: FeedItemFragment on Union - FeedItem
]
Duplicating generated selection set name FeedItemFragment.AsFollowRecommendationFeedItem.Followee.AsUser
Full Logs:
[ERROR - ApolloCodegenLib:SelectionSetTemplate.swift:182] - 4 mergedSources for operation(IR.Operation)
Sources: [entity: IR.Entity,
scopePath: [[Object - User]], fragment: rootField: UserListItemFragment: User!,
definition: UserListItemFragment on Object - User, entity: IR.Entity,
scopePath: [[Interface - Actor]], fragment: rootField: AvatarFragment: Actor!,
definition: AvatarFragment on Interface - Actor, entity: IR.Entity,
scopePath: [[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]], fragment: rootField: FeedItemFragment: FeedItem!,
definition: FeedItemFragment on Union - FeedItem, entity: IR.Entity,
scopePath: [[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]], fragment: rootField: FeedItemFragment: FeedItem!,
definition: FeedItemFragment on Union - FeedItem]
Duplicating generated selection set name FeedItemFragment.AsFollowRecommendationFeedItem.Followee.AsUser
[ERROR - ApolloCodegenLib:SelectionSetTemplate.swift:182] - 4 mergedSources for operation(IR.Operation)
Sources: [entity: IR.Entity,
scopePath: [[Object - User]], fragment: rootField: UserListItemFragment: User!,
definition: UserListItemFragment on Object - User, entity: IR.Entity,
scopePath: [[Interface - Actor]], fragment: rootField: AvatarFragment: Actor!,
definition: AvatarFragment on Interface - Actor, entity: IR.Entity,
scopePath: [[Union - FeedItem -> Object - FollowedUserFeedItem] -> [Union - Followable -> Object - User]], fragment: rootField: FeedItemFragment: FeedItem!,
definition: FeedItemFragment on Union - FeedItem, entity: IR.Entity,
scopePath: [[Union - FeedItem -> Object - FollowedUserFeedItem] -> [Union - Followable -> Object - User]], fragment: rootField: FeedItemFragment: FeedItem!,
definition: FeedItemFragment on Union - FeedItem]
Duplicating generated selection set name FeedItemFragment.AsFollowedUserFeedItem.Followee.AsUser
[ERROR - ApolloCodegenLib:SelectionSetTemplate.swift:182] - 4 mergedSources for operation(IR.Operation)
Sources: [entity: IR.Entity,
scopePath: [[Object - User]], fragment: rootField: UserListItemFragment: User!,
definition: UserListItemFragment on Object - User, entity: IR.Entity,
scopePath: [[Interface - Actor]], fragment: rootField: AvatarFragment: Actor!,
definition: AvatarFragment on Interface - Actor, entity: IR.Entity,
scopePath: [[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]], fragment: rootField: FeedItemFragment: FeedItem!,
definition: FeedItemFragment on Union - FeedItem, entity: IR.Entity,
scopePath: [[Union - FeedItem -> Object - FollowRecommendationFeedItem] -> [Union - Followable -> Object - User]], fragment: rootField: FeedItemFragment: FeedItem!,
definition: FeedItemFragment on Union - FeedItem]
Duplicating generated selection set name FeedItemFragment.AsFollowRecommendationFeedItem.Followee.AsUser
[ERROR - ApolloCodegenLib:SelectionSetTemplate.swift:182] - 4 mergedSources for operation(IR.Operation)
Sources: [entity: IR.Entity,
scopePath: [[Object - User]], fragment: rootField: UserListItemFragment: User!,
definition: UserListItemFragment on Object - User, entity: IR.Entity,
scopePath: [[Interface - Actor]], fragment: rootField: AvatarFragment: Actor!,
definition: AvatarFragment on Interface - Actor, entity: IR.Entity,
scopePath: [[Union - FeedItem -> Object - FollowedUserFeedItem] -> [Union - Followable -> Object - User]], fragment: rootField: FeedItemFragment: FeedItem!,
definition: FeedItemFragment on Union - FeedItem, entity: IR.Entity,
scopePath: [[Union - FeedItem -> Object - FollowedUserFeedItem] -> [Union - Followable -> Object - User]], fragment: rootField: FeedItemFragment: FeedItem!,
definition: FeedItemFragment on Union - FeedItem]
Duplicating generated selection set name FeedItemFragment.AsFollowedUserFeedItem.Followee.AsUser
With these more detailed logs, we still see no difference.
from apollo-ios.
AnthonyMDev
commented on September 24, 2024
@Iron-Ham, I know we weren't able to come up with a reproduction case for this yet. Are you still experiencing this bug?
from apollo-ios.
Related Issues (20)
- How should I continue after handleErrorAsync inside a custom ApolloErrorInterceptor? HOT 5
- Defining a CustomScalarType which is [String:Any] HOT 12
- Deprecate `legacyResponse` and prepare for partial/incremental caching HOT 2
- Custom scalar isn't being respected HOT 7
- @defer issue HOT 8
- Documentation for @import directive. HOT 9
- Add debugDescription api for Apollo generated types HOT 1
- Circular reference Build Error HOT 6
- Invalid redeclaration of synthesized property '_id' HOT 7
- Split/Hybrid Caching between InMemory and SQL review and thoughts HOT 4
- ID as a custom scalar HOT 6
- Bug: Cache writes of incremental responses uses incorrect parent key (custom cache keys)
- Incorrect PR link in release notes for version 1.11.0 HOT 2
- apollo-ios-cli deprecated --schema-name HOT 2
- Confused about cache behavior HOT 2
- CLI fails to run with 1.12.0 HOT 4
- Response value getting nil HOT 2
- Version mismatch between package and CLI HOT 3
- Pagination: Pager does not provide updates during a refresh HOT 6
- Slow compilation speed when migrating from 0.x to 1.12.2 HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apollo-ios.