[apollo-datasource-rest] Handling 404 errors about datasource-rest HOT 2 OPEN

I am also looking for best practices on this...

My current challenge is how to handle this during a server-side render(SSR). In the case of the REST API returning a 404, it causes a 404 error to be thrown, which then has to be handled within a catch statement. I have logic in the Query component for handling this behavior but during a SSR this logic is never hit because it throws exceptions instead.

Your solution is an option but painful like you said.

Another option, which I am not happy with, is setting the errorPolicy="all" on the Query component.

This causes the SSR to succeed and allows the apollo client to cache all the other successful responses. However, it then causes the client to re-issue the request and handle it accordingly, which results in the re-issuing same request the server already performed.

from datasource-rest.

I just ran into this myself, although in my case it was in the context of testing with an intentionally bad id for the API I'm hitting - i.e. expect(doTheThing(badId)).toThrow() or .toEqual(null) and the 404 was breaking it.

Here's a less painful version of the original solution, making use of the fact that await is just a fancy Promise:

return dataSources.listingApi.getListing(args.reference)
  .catch(err => {
    if(err.extensions.response.status === 404) {
      return null;
    }
      throw err;
    }
  })

• Note that return await is unnecessary in an async function; you can just return the awaited expression.
• This will get even shorter if throw expressions are added to ES (currently Stage 2, and available with Babel:

.catch(err => ((err.extensions.response.status === 404) ? null : throw err)

from datasource-rest.