right now coprocessor calls cannot appear in the request trace because we don't transm

propagate tracing headers to coprocessor calls about router HOT 1 CLOSED

Geal commented on June 1, 2024

propagate tracing headers to coprocessor calls

from router.

Comments (1)

Geal commented on June 1, 2024

I have just checked, coprocessors already propagate tracing headers:

router/apollo-router/src/services/external.rs

Lines 268 to 292 in a709cff

 pub(crate) async fn call<C>(self, mut client: C, uri: &str) -> Result<Self, BoxError> 

 where 

 C: Service<hyper::Request<Body>, Response = hyper::Response<Body>, Error = BoxError> 

 + Clone 

 + Send 

 + Sync 

 + 'static, 

 { 

 tracing::debug!("forwarding json: {}", serde_json::to_string(&self)?); 

 let mut request = hyper::Request::builder() 

 .uri(uri) 

 .method(Method::POST) 

 .header(ACCEPT, "application/json") 

 .header(CONTENT_TYPE, "application/json") 

 .body(serde_json::to_vec(&self)?.into())?; 

 get_text_map_propagator(|propagator| { 

 propagator.inject_context( 

 &prepare_context(tracing::span::Span::current().context()), 

 &mut opentelemetry_http::HeaderInjector(request.headers_mut()), 

 ); 

 }); 

 let response = client.call(request).await?;

cc @BrynCooke

from router.

propagate tracing headers to coprocessor calls about router HOT 1 CLOSED

Comments (1)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	pub(crate) async fn call<C>(self, mut client: C, uri: &str) -> Result<Self, BoxError>
	where
	C: Service<hyper::Request<Body>, Response = hyper::Response<Body>, Error = BoxError>
	+ Clone
	+ Send
	+ Sync
	+ 'static,
	{
	tracing::debug!("forwarding json: {}", serde_json::to_string(&self)?);

	let mut request = hyper::Request::builder()
	.uri(uri)
	.method(Method::POST)
	.header(ACCEPT, "application/json")
	.header(CONTENT_TYPE, "application/json")
	.body(serde_json::to_vec(&self)?.into())?;

	get_text_map_propagator(\|propagator\| {
	propagator.inject_context(
	&prepare_context(tracing::span::Span::current().context()),
	&mut opentelemetry_http::HeaderInjector(request.headers_mut()),
	);
	});

	let response = client.call(request).await?;