Comments (6)
boutell
commented on June 24, 2024
This module does work as designed in our experience — is there a particular configuration or combination of modules needed to trigger this "shows login button no matter what" behavior?
from apostrophe-second-chance-login.
jansensan
commented on June 24, 2024
The projects are also using apostrophe-workflow, could that affect the behaviour?
As a user (as opposed to anon), the 404 page is reachable, and it shows as unpublished (linked to the workflow?), but clicking on the big red button offers no option to publish a notFound template... (which sort of makes sense).
from apostrophe-second-chance-login.
boutell
commented on June 24, 2024
Honestly not sure. Does it occur in a simple boilerplate project? How about
when you add workflow to that project?
…On Thu, Apr 15, 2021 at 11:59 AM Mat Janson Blanchet < ***@***.***> wrote:
The projects are also using apostrophe-workflow, could that affect the
behaviour?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAH27L4C7YQASUNDSX2L33TI4EOTANCNFSM426CDFDA>
.
--
THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER
APOSTROPHECMS | apostrophecms.com | he/him/his
from apostrophe-second-chance-login.
jansensan
commented on June 24, 2024
Will create this proto/boilerplate/test as soon as I can (likely mid next week) and will come back to you here
from apostrophe-second-chance-login.
jansensan
commented on June 24, 2024
@boutell So I created a project from the boilerplate, added workflow and second chance login, and indeed, an actual 404 does go to the login page.
URL: https://github.com/jansensan/apostrophecms-404-issue
TODO: create the admin user (as you would when running the boilerplate project)
These would be my behavioral expectations:
- If the page/piece exists and is not covered by the current permissions (e.g. anon), yes lead the user to the login page
- If the page/piece does not exist, the 404 page/template should be served to the user
from apostrophe-second-chance-login.
boutell
commented on June 24, 2024
OK, thanks for verifying that. It seems reasonable that this ticket stay
here in second chance login rather than in workflow, but it's important for
us to know it won't happen unless workflow is present.
…On Tue, Apr 20, 2021 at 2:07 PM Mat Janson Blanchet < ***@***.***> wrote:
@boutell <https://github.com/boutell> So I created a project from the
boilerplate, added workflow and second chance login, and indeed, an actual
404 does go to the login page.
URL: https://github.com/jansensan/apostrophecms-404-issue
TODO: create the admin user (as you would when running the boilerplate
project)
These would be my behavioral expectations:
- If the page/piece exists and is not covered by the current
permissions (e.g. anon), yes lead the user to the login page
- If the page/piece does not exist, the 404 page/template should be
served to the user
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAH27NB6TLUUL2MTMELYQLTJW7HVANCNFSM426CDFDA>
.
--
THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER
APOSTROPHECMS | apostrophecms.com | he/him/his
from apostrophe-second-chance-login.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apostrophe-second-chance-login.