Giter VIP home page Giter VIP logo

Comments (5)

Omegaviv avatar Omegaviv commented on June 13, 2024 1

okay I will create a issue on AppFlowy-plugin repository and push the changes there.

from appflowy.

Xazin avatar Xazin commented on June 13, 2024 1

okay I will create a issue on AppFlowy-plugin repository and push the changes there.

Thanks a lot, feel free to DM me or reach out on our discord if you have questions or if I can assist you with anything.

from appflowy.

Omegaviv avatar Omegaviv commented on June 13, 2024

@Xazin can I work on this?

from appflowy.

Omegaviv avatar Omegaviv commented on June 13, 2024

@LucasXu0 as @Xazin has mentioned to display Page title and url, so according to the current implementation there is no Page title metadata on LinkPreviewNode

image

from appflowy.

Xazin avatar Xazin commented on June 13, 2024

@LucasXu0 as @Xazin has mentioned to display Page title and url, so according to the current implementation there is no Page title metadata on LinkPreviewNode

This requires a change to the Link Preview Block, we should store the metadata when it's first loaded on the node itself.

What if the site has changed since? We can add an action to reload the metadata in case the author thinks it's wrong, which would go on to refetch the metadata. This way we also don't have to refetch it for every single user, it's enough to fetch it once for all users.

from appflowy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.