Giter VIP home page Giter VIP logo

Comments (6)

RazZziel avatar RazZziel commented on August 15, 2024

Is pygtk2 needed also in the experimental branch, when not using the GUI?

from appimagekit.

probonopd avatar probonopd commented on August 15, 2024

i'm still fighting to compile experiemental

from appimagekit.

probonopd avatar probonopd commented on August 15, 2024

6ac5788 closes this. Actually this had been working before it was broken by 364f271

from appimagekit.

RazZziel avatar RazZziel commented on August 15, 2024

Ok, the problem was then that 364f271 deliberately removed support for running the application with just three arguments in order to pack, when adding the --pack and --unpack commands, because it was ambiguous, so you weren't actually running in CLI mode.

If the old behavior needs to be respected, it could've been added after the loop that checks for --pack, --unpack, etc.

Also please bear in mind that
os.system(os.path.dirname(__file__) + "/package %s %s" % (sys.argv[1], sys.argv[2]))
instead of
os.system(os.path.dirname(__file__) + "/package '%s' '%s'" % (sys.argv[1], sys.argv[2]))
will not respect spaces in filenames

from appimagekit.

probonopd avatar probonopd commented on August 15, 2024

What do you mean by "it was ambiguous, so you weren't actually running in CLI mode"?

Personally, I prefer cp a b over cp --from a --to b ;-)

Changing the syntax broke build scripts which depended on it.

from appimagekit.

RazZziel avatar RazZziel commented on August 15, 2024

My bad, I should've discussed before happily changing the paradigm of the tool operation:

  • cp a b works well for cp, because that's the only thing cp does: copying
  • Package format managers like tar, zip, 7z, etc, on the other hand, need to specify a command in every invocation, usually pack, unpack, and test/list.

I understand AppImageAssistant to be in the same group as tar, zip and 7z: one single tool to operate with AppImages. It is true that AppImageAssistant is different, in the sense that if run without arguments it will pop up a nice UI to make it compatible with doube-clickers, and specially in the sense that the pack command is more important here than the unpack command because there's usually no need for the user to unpack an AppImage (compared to the other tools, where packing is just as important as unpacking), but I still think further operations with AppImages should be allowed, even if we let the pack command to be the protagonist, allowing it to be run without explicitly declaring --pack.

What do you mean by "it was ambiguous, so you weren't actually running in CLI mode"?

it was ambiguous

I meant that no command was specified, although now I think it'd be fine to keep this behavior in this case, being the pack operation more important than any other operation for AppImages

so you weren't actually running in CLI mode

My patch implied that you'd run in CLI mode only if an explicit --pack, --unpack or --help command was specified, so if you just specified your three arguments without command, the tool would just ignore the arguments, start the GUI, and fail when trying to load Gtk.

from appimagekit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.