Giter VIP home page Giter VIP logo

Comments (10)

probonopd avatar probonopd commented on May 26, 2024

I don't know why it is scanning there, it is supposed to scan only https://github.com/AppImage/appimaged#monitored-directories

from appimaged.

blackPantherOS avatar blackPantherOS commented on May 26, 2024

Of course, I know because I see in code as well..
Okay, I will remove all patches which we used to previous versions and I will try again.

from appimaged.

probonopd avatar probonopd commented on May 26, 2024

Does your system have some symlinks in the scanned places, maybe?

from appimaged.

blackPantherOS avatar blackPantherOS commented on May 26, 2024

Ok, I found the origin of this problem, in main.c

    - add_dir_to_watch(g_get_user_special_dir(G_USER_DIRECTORY_DOWNLOAD));
    +// add_dir_to_watch(g_get_user_special_dir(G_USER_DIRECTORY_DOWNLOAD));

The problem is persists If the user own Home directory set as to download destination. I've added this patch and this solve my problem and the our users as well.

from appimaged.

probonopd avatar probonopd commented on May 26, 2024

It looks like your setup is deviating from what can be considered the usual default:

  • The download directory should not be $HOME but rather something within it; normally it is $HOME/Downloads. Is your somewhat strange setup intentional, and why?
  • If you disable watching the downloads directory, freshly downloaded AppImages will not be integrated into the system automatically, is that what you intend, and why?

from appimaged.

probonopd avatar probonopd commented on May 26, 2024

Do you have a Live ISO available for testing your system?

from appimaged.

blackPantherOS avatar blackPantherOS commented on May 26, 2024

"normally it is $HOME/Downloads. Is your somewhat strange setup intentional, and why?"

I want organize files, and don't want many different files in Downloads directory. And I was work on XDG few days ago and we try many different settings. Any problem occurred with XDG, the XDG default value is set to $HOME. I require be prepared system for any user mistakes as well.

My suggestion to your code, the subdirectory does not exists,it should be removed from watching path,

"If you disable watching the downloads directory, freshly downloaded AppImages will not be integrated into the system automatically,"

Your first idea is good, but I think not so good place the user's download directory to runing any application. We made a dialog based "first start wizard" this create one '$HOME/.Appimage' directory and a localized symlink to -> '$HOME/Applications'. The appimaged watching this directory only.
If we provide many AppImage dir to watching, the user can mixing many application version, this is not good and insecure things as well.

"Do you have a Live ISO available for testing your system?"
The old version of course vailable on our ftp servers or webpage. The new beta of next version still not, but will be available in two weeks between. The patched appimaged for beta available here now.
ftp://ftp.blackpantheros.eu/blackPanther/OS/All/v18.x/64bit/media1/appimaged-11~git20181021-1bP.x86_64.rpm

Sry if my English not so good:)

from appimaged.

probonopd avatar probonopd commented on May 26, 2024

Thanks for the clarification.

My suggestion to your code, the subdirectory does not exists,it should be removed from watching path

If one of the directories to be watched does not exist, then it can't (and should not) be watched. Is it not how it is behaving today?

from appimaged.

blackPantherOS avatar blackPantherOS commented on May 26, 2024

👍 Okay, this is a mistake and my bad english, sorry... so, so :)
I think to this:
`[ "$(xdg-user-dir DOWNLOAD)" == "$HOME" ] && exit

Its okay?:)

from appimaged.

probonopd avatar probonopd commented on May 26, 2024

Yes, I see. That's a good idea for your case.

from appimaged.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.