Giter VIP home page Giter VIP logo

Comments (14)

TheAssassin avatar TheAssassin commented on June 6, 2024

That file must be run at least once to create the thumbnail. Did you run it?

from appimaged.

probonopd avatar probonopd commented on June 6, 2024

I have appimaged installed and I assume it creates the thumbnails? No?

from appimaged.

TheAssassin avatar TheAssassin commented on June 6, 2024

Not sure whether it does. You should check your source code... I only know for sure that thumbnails are created by the runtime on execution.

from appimaged.

probonopd avatar probonopd commented on June 6, 2024

But no, also after running it there is still no thumbnail.

from appimaged.

probonopd avatar probonopd commented on June 6, 2024

The inside of the AppImage looks immaculate:

user@clr-b8cf94b408544d1a88c7b8ad7ecfb2cf ~ $ find /tmp/.mount_jitsi-SDKBVq/ | grep .png$
/tmp/.mount_jitsi-SDKBVq/jitsi-meet.png
/tmp/.mount_jitsi-SDKBVq/usr/share/icons/hicolor/128x128/apps/jitsi-meet.png
/tmp/.mount_jitsi-SDKBVq/usr/share/icons/hicolor/16x16/apps/jitsi-meet.png
/tmp/.mount_jitsi-SDKBVq/usr/share/icons/hicolor/24x24/apps/jitsi-meet.png
/tmp/.mount_jitsi-SDKBVq/usr/share/icons/hicolor/256x256/apps/jitsi-meet.png
/tmp/.mount_jitsi-SDKBVq/usr/share/icons/hicolor/32x32/apps/jitsi-meet.png
/tmp/.mount_jitsi-SDKBVq/usr/share/icons/hicolor/48x48/apps/jitsi-meet.png
/tmp/.mount_jitsi-SDKBVq/usr/share/icons/hicolor/512x512/apps/jitsi-meet.png
/tmp/.mount_jitsi-SDKBVq/usr/share/icons/hicolor/64x64/apps/jitsi-meet.png
/tmp/.mount_jitsi-SDKBVq/usr/share/icons/hicolor/96x96/apps/jitsi-meet.png
user@clr-b8cf94b408544d1a88c7b8ad7ecfb2cf ~ $ grep -r Icon= /tmp/.mount_jitsi-SDKBVq/jitsi-meet.desktop 
Icon=jitsi-meet

from appimaged.

TheAssassin avatar TheAssassin commented on June 6, 2024

The thumbnail is created from the .DirIcon.

from appimaged.

probonopd avatar probonopd commented on June 6, 2024

...which is missing indeed:

user@clr-b8cf94b408544d1a88c7b8ad7ecfb2cf ~ $ find /tmp/.mount_jitsi-SDKBVq/ | grep DirIcon
(nothing)

Bug in electron-builder?

from appimaged.

TheAssassin avatar TheAssassin commented on June 6, 2024

They violate the AppDir specification (which someone renamed for some reason ... ... ...).

It's a specification! And only if you call it that way, people will adhere to it!

from appimaged.

TheAssassin avatar TheAssassin commented on June 6, 2024

Also, don't rename references in Sphinx without doing it anywhere. Now, we have broken references...

from appimaged.

probonopd avatar probonopd commented on June 6, 2024

Ouch! What is the proper way to edit this? Remember, my level of sophistication is editing .md

from appimaged.

probonopd avatar probonopd commented on June 6, 2024

One could see it as:

  • AppDir 1.0 specification = ROX Filer's original spec
  • AppDir 2.0 specification = our "liberal" interpretation thereof?
  • AppDir 3.0 specification = official XDG specification?

from appimaged.

TheAssassin avatar TheAssassin commented on June 6, 2024

Only what we don't own the AppDir specification, as it's a specification from the ROX filer people.

I reverted the commit with the following description:

    Revert ""description", not "specification""
    
    We **extended** the AppDir format. If you like OOP terms, we inherit
    the AppDir specification, and extend it.
    
    Also, references must not be renamed in a single file only (especially
    not the declaration), otherwise things will break.

It is our specification, as we add additional rules to it. So it is our specification, even if the text is not in RFC style.

from appimaged.

TheAssassin avatar TheAssassin commented on June 6, 2024

Remember, my level of sophistication is editing .md

There is no difference whether to do it in .md or .rst (only that Markdown doesn't have real references). If you rename a heading in Markdown, but don't apply the change in all files that link to it, links will break. That's why many links in Wikis are broken (like in the old AppImageKit wiki).

The proper way is to do it using sed. But in terms of ReST, there is no real reason to rename references. Their internal identifiers only, links will rename automatically unless they have a custom title anyway.

The Travis CI build perfoms a link check that identifies such problems. But ideally, you do it by building locally, and applying a link change before committing. (I know that's not so much your style, hence the Travis build.)

from appimaged.

TheAssassin avatar TheAssassin commented on June 6, 2024

By the way, see https://docs.appimage.org/reference/appdir.html#history for a description why we call it specification. We do of course credit ROX filer.

from appimaged.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.