Giter VIP home page Giter VIP logo

Comments (9)

TheAssassin avatar TheAssassin commented on June 4, 2024

Well, initially you suggested to look for updates only on errors. That's what's implemented. I don't see the bug here, the self update is not triggered at all, everything works as intended.

from appimageupdate.

TheAssassin avatar TheAssassin commented on June 4, 2024

Feel free to reopen if you think this behavior should change.

from appimageupdate.

probonopd avatar probonopd commented on June 4, 2024

...yes but I believe this AppImage is not up to date. Is it?

me@host:~$ sha1sum '/home/me/Downloads/AppImageUpdate-x86_64 (1).AppImage'
f5f61a352bd7edd8984464c010cd3b1981537c69  /home/me/Downloads/AppImageUpdate-x86_64 (1).AppImage

from appimageupdate.

TheAssassin avatar TheAssassin commented on June 4, 2024

Ok, I think I misunderstood your report. You're saying that AppImageUpdate fails to update itself when called like AppImageUpdate.AppImage AppImageUpdate.AppImage. However, that doesn't have anything to do with the self-updating functionality.

I'd suggest to retitle the issue.

Possibly related to the broken update check #21.

from appimageupdate.

probonopd avatar probonopd commented on June 4, 2024

Right, the current one (as of now) has d978f47d348054ad6cfb35e5e8f1cd8f26c49c3a

from appimageupdate.

TheAssassin avatar TheAssassin commented on June 4, 2024

I adjusted the title, and would ask you to take care not to use the words "self" and "update" in the same context like this to avoid ambiguous situations like this. I thought of AppImageSelfUpdate, which is implemented in AppImageUpdate AppImages, serving as a kind of reference implementation.

from appimageupdate.

probonopd avatar probonopd commented on June 4, 2024

Ah ok. Thanks for looking into this.

from appimageupdate.

probonopd avatar probonopd commented on June 4, 2024

AppImageUpdate-x86_64 (1).AppImage.zip

Maybe helpful to reproduce this. Zipped for GitHub Issues.

from appimageupdate.

TheAssassin avatar TheAssassin commented on June 4, 2024

Turned out the update check had a few minor flaws (fixed in AppImageCommunity/zsync2@f61d8ac).

Another issue occurred due to libzsync not being able to resolve redirections of URLs. To fix that behaviour, I'm using a HEAD request to resolve the final URL before passing it to libzsync, which seems to have solved the issue. See AppImageCommunity/zsync2@af6aab8.

I'm closing this issue, but would ask you to verify that it works now.

from appimageupdate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.