Giter VIP home page Giter VIP logo

Comments (21)

probonopd avatar probonopd commented on May 24, 2024

This is also shown in the FLTK documentation, notice the missing icon in the upper left:

from appimageupdate.

probonopd avatar probonopd commented on May 24, 2024

Possily we need to use http://www.fltk.org/doc-1.3/classFl__Window.html#a508f3acd43f9b365d35897b5ec197dbe

from appimageupdate.

TheAssassin avatar TheAssassin commented on May 24, 2024

I am not aware of any option to set an icon for a native file chooser. I looked it up, and couldn't find anything for the native one, but the non-native implementation seems to support it. However, the native one looks way better, and I don't think this is really a bug, it's more of a "nice to have" feature.

The icon is also missing in the main application window. I'm going to fix that as soon as possible.

from appimageupdate.

probonopd avatar probonopd commented on May 24, 2024

On Ubuntu 17.10, getting with 84e3b3d:

me@host:~$ chmod +x AppImageUpdate-84e3b3d-x86_64.AppImage 
me@host:~$ ./AppImageUpdate-84e3b3d-x86_64.AppImage 
./AppImageUpdate-84e3b3d-x86_64.AppImage: error while loading shared libraries: libpng12.so.0: cannot open shared object file: No such file or directory

from appimageupdate.

TheAssassin avatar TheAssassin commented on May 24, 2024

That library might be pulled in by the new fltk_images build dependency. I'm not sure why it isn't bundled.

from appimageupdate.

probonopd avatar probonopd commented on May 24, 2024

Still in 6555252:

me@host:~$ /home/me/AppImageUpdate-6555252-x86_64.AppImage: error while loading shared libraries: libpng12.so.0: cannot open shared object file: No such file or directory

from appimageupdate.

TheAssassin avatar TheAssassin commented on May 24, 2024

Will debug as soon as possible.

from appimageupdate.

TheAssassin avatar TheAssassin commented on May 24, 2024

My local builds link to libpng as well. I don't know what causes linuxdeployqt not to see the dependency and bundle the library. Strange problem, indeed.

from appimageupdate.

TheAssassin avatar TheAssassin commented on May 24, 2024

A bunch of other libraries are missing as well. The majority are dependencies of libcurl (need to bundle my custom build from OBS as soon as possible), but a few other libraries like libjpeg, libXpm etc. should've been bundled.

from appimageupdate.

TheAssassin avatar TheAssassin commented on May 24, 2024

See https://travis-ci.org/AppImage/AppImageUpdate/builds/301084251#L1965-L1970

I have to add = signs for the -executable parameters as specified here:

Options:
...
   -executable=<path>  : Let the given executable use the deployed libraries too

https://github.com/probonopd/linuxdeployqt#usage

from appimageupdate.

TheAssassin avatar TheAssassin commented on May 24, 2024

Library issues have been fixed in 352e751.

from appimageupdate.

TheAssassin avatar TheAssassin commented on May 24, 2024

Works.

from appimageupdate.

probonopd avatar probonopd commented on May 24, 2024

At least in Deepin Linux it is not working:

deepinbildschirmfoto20171113074252

That glaring gaop there is AppImageUpdate.
But this has lower priority for now.

from appimageupdate.

TheAssassin avatar TheAssassin commented on May 24, 2024

@probonopd that might be another Linux Desktop Platform Issue. FLTK docs mention you need to load a WM specific icon format. I load XPM now, which seems to be the format for most DEs. If you find out what format is needed for Deepin, I'll add something about it to libDE.

from appimageupdate.

probonopd avatar probonopd commented on May 24, 2024

@TheAssassin unfortunately I get the same result in Ubuntu 17.10.
png or svg should work everywhere, xpm is the worst of the formats and imho legacy.

Btw, I think the errors shown on the console are unrelated to the main application menu missing from the left-hand side Ubuntu GNOME dock.

ubuntu1710

from appimageupdate.

probonopd avatar probonopd commented on May 24, 2024

I think I found the reason:

usr/share/icons/hicolor/scalable/AppImage.svg needs to be usr/share/icons/hicolor/scalable/apps/AppImage.svg, apps is missing...

from appimageupdate.

probonopd avatar probonopd commented on May 24, 2024

Trying to fix in 7a1358b

(name is wrong - I meant #38 not #18)

from appimageupdate.

TheAssassin avatar TheAssassin commented on May 24, 2024

I think I found the reason:

usr/share/icons/hicolor/scalable/AppImage.svg needs to be
usr/share/icons/hicolor/scalable/apps/AppImage.svg, apps is missing...

This doesn't have anything to do with it. The .desktop file doesn't specify what icon is sent to the WM, the application decides what it sends to X11. See https://github.com/AppImage/AppImageUpdate/blob/rewrite/src/gui_main.cpp#L155-L172. You can't just call window.icon with PNG file contents. But I'm not even sure whether the XPM code is 100% right, I haven't really tested that too much in detail. I found it works fine on my xubuntu 16.04 desktop, just tested with 7a1358b.

from appimageupdate.

TheAssassin avatar TheAssassin commented on May 24, 2024

Window icon works fine, but there is no icon in the task bar on Kubuntu 17.10. Strange.

from appimageupdate.

TheAssassin avatar TheAssassin commented on May 24, 2024

@probonopd could you try whether the issue has been resolved with the Qt version?

from appimageupdate.

TheAssassin avatar TheAssassin commented on May 24, 2024

Closing for now. Feel free to reopen, and please attach a screenshot and the OS and version you found this to be an issue on.

from appimageupdate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.