Comments (7)
StefMa
commented on June 8, 2024
1
Kotlin toolchain support is available since 1.5.30. Gradle introduced the base of this feature in 6.7 or maybe 7.0 (to stable).
So I guess we are fine here.
I will try it out and report back 👍
from pkl.
stackoverflow
commented on June 8, 2024
1
When you run ./gradlew updateDependencyLocks you update all dependencies, which is not what you want. You can use gradle classes --update-locks some:dependency to only update what you need. See here for more info: https://docs.gradle.org/current/userguide/dependency_locking.html#selectively_updating_lock_state_entries.
from pkl.
stackoverflow
commented on June 8, 2024
This seems like a good idea. Feel free to contribute a PR if you so wish.
from pkl.
holzensp
commented on June 8, 2024
I thought it wasn't extended to Kotlin toolchains yet in Gradle 7 (and we're still pending the bump to >=8.6)
from pkl.
StefMa
commented on June 8, 2024
So I tested a bit:
The foojay-toolchain-plugin requires at least Gradle 7.6.
So we can't use it right know until #200 is fixed and merged.
Nevertheless, I update Gradle and made the required changes.
👉 https://pastebin.com/6kJu02YV
Suddently I get a lockfile issue running ./gradlew assemble.
> Task :pkl-gradle:compileJava FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':pkl-gradle:compileJava'.
> Could not resolve all files for configuration ':pkl-gradle:compileClasspath'.
> Did not resolve 'org.jetbrains.kotlin:kotlin-stdlib:1.7.10' which is part of the dependency lock state
> Did not resolve 'org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10' which is part of the dependency lock state
> Did not resolve 'org.jetbrains:annotations:13.0' which is part of the dependency lock state
> Did not resolve 'org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.10' which is part of the dependency lock state
> Did not resolve 'com.github.ajalt.clikt:clikt-jvm:3.5.1' which is part of the dependency lock state
> Did not resolve 'com.github.ajalt.clikt:clikt:3.5.1' which is part of the dependency lock state
> Did not resolve 'org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.10' which is part of the dependency lock state
I don't know where this is coming from and how to fix it 😞 .
When running ./gradlew updateDependencyLocks I get a lot of changes ❗
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: bench/gradle.lockfile
modified: docs/gradle.lockfile
modified: pkl-cli/gradle.lockfile
modified: pkl-codegen-java/gradle.lockfile
modified: pkl-codegen-kotlin/gradle.lockfile
modified: pkl-commons-cli/gradle.lockfile
modified: pkl-commons-test/gradle.lockfile
modified: pkl-commons/gradle.lockfile
modified: pkl-config-java/gradle.lockfile
modified: pkl-config-kotlin/gradle.lockfile
modified: pkl-core/gradle.lockfile
modified: pkl-doc/gradle.lockfile
modified: pkl-executor/gradle.lockfile
modified: pkl-gradle/gradle.lockfile
modified: pkl-server/gradle.lockfile
modified: pkl-tools/gradle.lockfile
modified: stdlib/gradle.lockfile
However, afterwards I get another issue 😅
FAILURE: Build failed with an exception.
* What went wrong:
Could not determine the dependencies of task ':pkl-tools:shadowJar'.
> Could not resolve all dependencies for configuration ':pkl-tools:runtimeClasspath'.
> Resolved 'org.jetbrains.kotlin:kotlin-stdlib-common:1.9.22' which is not part of the dependency lock state
from pkl.
holzensp
commented on June 8, 2024
I forget about the Kotlin stdlib intricacies for shadowJar. @stackoverflow / @bioball, thoughts?
from pkl.
StefMa
commented on June 8, 2024
Could you explain this a bit more to me? 🤔
What is the issue Iam facing I don't get it...
from pkl.
Related Issues (20)
- Automatic formatting of Pkl files HOT 1
- Stack overflow when parameter name is same as object property name HOT 2
- Type constraints on `typealias`es are evaluated eagerly HOT 3
- Question: Submit to CNCF HOT 3
- `gw buildNative` runs aarch64 tasks on amd64 HOT 1
- Allow overriding Java/Kotlin package name in codegen
- Rendering lists in XML may produce unexpected results HOT 1
- Type constraints are sometimes not enforced. HOT 2
- Unable to create test for non-empty constraint on listing HOT 2
- Add SLSA provenance to your releases
- Disable "Allow merge commits" and "Allow rebase merging" in GitHub UI HOT 3
- Non-constant globbed reads return wrong results
- Reads with same glob pattern return same result even if located in different modules/directories
- better source listing for IntelliJ to include line numbers? HOT 2
- Provide an ability to depend on a local project module from a non-project module
- Feature Request: Add `hcl` format
- [Feature Request] Type parameters for Classes
- Unexpected caching with pkl-go and Evaluator.EvaluateOutputText HOT 1
- Output path placeholders don't expose `ValueRenderer.extension`
- Optimization: `const` members should be cached for all children in prototype chain
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pkl.