JPMS modules about pkl HOT 4 OPEN

We're looking into moving off of both ANTLR and said collections library. Especially a collections lib is tricky.

It would really help rolling this in if you could flesh out (links to issues etc) this description somewhat (or go straight ahead and submit a PR) It doesn't even seem unreasonable to me to keep a Draft PR going, pending replacement of ANTLR & Paguro removal.

from pkl.

Sure, I could make a PR. Though, shaded JARs could be a problem there (especially pkl-cli-java, afaict), you kinda have to either make them not modules, or relocate the packages of dependencies to avoid any conflicts.
Regarding issue links - upstream ANTLR does have an automatic module name as well which would make depending on it from a named module possible, but no module-info by itself yet (see antlr/antlr4#2946), while the fork doesn't. Paguro seems to be inactive, but I guess I could try to open an issue/send a PR there as well.

from pkl.

The org.pkl.core.parser.antlr.pklLexer class conflicts with other artifacts using the original version of the antlr-runtime and fails in runtime, due to fully incompatible versions of the ATNDeserializer (at least that). It would be great to either migrate to the original antlr or to move off of antlr.

Meanwhile, can someone think of a workaround to such a conflict?

from pkl.

@holzensp I've built a version of Paguro and Antlr4 locally which uses modules, allowing Pkl to build with a full modulepath compile. Since Pkl intends to move off these libraries eventually, they probably won't get version bumped (and see little activity anyway). If you'd like, I can post a PR which uses these libs.

from pkl.