Giter VIP home page Giter VIP logo

Comments (4)

Lukasa avatar Lukasa commented on June 3, 2024

This is definitely something we can and should enable. I think the patch required to do it should be fairly easy: are you interested in trying to tackle it?

from swift-certificates.

jschlesser avatar jschlesser commented on June 3, 2024

👋 @Lukasa,
Hmm, if you think it's fine, I'll give it a try. I'm very new to Swift. Other than the probably overly ambitious hobby project that I'm working on this would be my first project addition in Swift and first for an Apple platform. I'm not new to programming, but definitely to programming Swift and for macOS. On the surface it seems like straight forward additions in the CertificatePrivateKey and CertificatePublicKey extensions. On the other hand I will need to add CryptoKit as a dependency and I think the SecureEnclave stuff is only available on later versions of some Apple platforms tvOS(15.0+) https://developer.apple.com/documentation/cryptokit/ and not at all on non apple platforms. Is this going to be testable in Docker? I don't have any idea about how to do the platform checking etc... nor how to conditionally make binaries for CryptoKit enabled platforms. I'm willing to give it a shot though if you think it's a good first addition and are willing to coach me through it or you don't think I need to worry about things I'm worrying about.

from swift-certificates.

Lukasa avatar Lukasa commented on June 3, 2024

I'm happy to coach you through it.

Importantly you don't need to import CryptoKit: swift-crypto makes it implicitly available. You only need to guard by platform, as you can see in swift-nio-ssh (search for SecureEnclave).

We can't CI this change on the non-apple platforms, so we'll have to do local testing to confirm it works, but that should be fine. The scope of the change will ultimately be small, as the public key doesn't need to be changed (SecureEnclave public keys are the same type as non-SE ones). It's very possible that the entire scope of the change is in CertificatePrivateKey.swift and the associated tests you'll want to write.

from swift-certificates.

Lukasa avatar Lukasa commented on June 3, 2024

Resolved by #55.

from swift-certificates.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.