Angle type about swift-numerics HOT 5 OPEN

Random thought...

Having Angle<T: Real> be a struct is good, because it makes it easy to add different representations of the underlying angle. You could easily add a public var turns: T, a public var gons: T, etc.

from swift-numerics.

I've thought about this design in the past (and did an implementation back in Swift 2 that I never published); it would be as-well-as, rather than instead-of, but it's not actually a bad idea. You start to get into weird typing questions if you aggressively go down this path with the trig functions (by analogy, exp should produce a result type that differs from its argument, with log having the reverse signature, and we need to make the types relate to the angle type when we move to complex operations), but for simpler use cases it can be pretty nice.

from swift-numerics.

I'm also in favor of the Angle type. In my code base I constantly have to keep in mind if the angle in a given block of code is in radians or degrees (hint: it's always the Angle type).

I'd be more than happy to help here if needed. Forgive me for asking, but what is the consensus: is the issue still relevant (PR/implementation needed) or is there more discussion required?

from swift-numerics.

from swift-numerics.

Gradians are a metric version of radians. Probably not used much but handheld calculators always had a "DRG" key which supported degrees, radians, and gradians. Noticed, that Apple's calculator does not support it.

from swift-numerics.