Giter VIP home page Giter VIP logo

Comments (6)

isidore avatar isidore commented on June 13, 2024

this should be very possible, but would need a doctest expert to pair with. Usually this is a 30-40 minute thing with an expert. Are you that person?

from approvaltests.cpp.

claremacrae avatar claremacrae commented on June 13, 2024

If doing this, I'd suggest first moving the Catch2, GoogleTest and Okra implementations in to a sub-directory, as I hope that this list of supported frameworks will keep on growing...
See https://github.com/approvals/ApprovalTests.cpp/tree/master/ApprovalTests

It looks like doctest does have the ability to listen out for new tests:
https://github.com/onqtam/doctest/blob/master/examples/all_features/reporters_and_listeners.cpp

from approvaltests.cpp.

zhihaoy avatar zhihaoy commented on June 13, 2024

this should be very possible, but would need a doctest expert to pair with. Usually this is a 30-40 minute thing with an expert. Are you that person?

I only have time to use it :)

It looks like doctest does have the ability to listen out for new tests:
https://github.com/onqtam/doctest/blob/master/examples/all_features/reporters_and_listeners.cpp

And DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN, DOCTEST_REGISTER_REPORTER.

from approvaltests.cpp.

claremacrae avatar claremacrae commented on June 13, 2024

Hi, no worries... Thanks very much for the suggestion - and for letting us know about another testing framework.

I really like its promise of faster build times!

from approvaltests.cpp.

claremacrae avatar claremacrae commented on June 13, 2024

Things that I'm aware of that we still need to do

  • Fix the Windows builds
  • Remove using namespace doctest; in ApprovalTests/integrations/doctest/DocTestApprovals.h
  • Fix the stomping on --reporter command-line argument in our doctest main - depends on doctest/doctest#257 or doctest/doctest#260
  • Fix compiler warnings:

/cygdrive/d/Users/Clare/Documents/Programming/github/ApprovalTests/ApprovalTests.cpp/ApprovalTests/integrations/doctest/DocTestApprovals.h:16:8: warning: 'DocTestApprovalListener' has a field 'DocTestApprovalListener::' whose type uses the anonymous namespace [-Wsubobject-linkage]
struct DocTestApprovalListener : ConsoleReporter
^~~~~~~~~~~~~~~~~~~~~~~
/cygdrive/d/Users/Clare/Documents/Programming/github/ApprovalTests/ApprovalTests.cpp/ApprovalTests/integrations/doctest/DocTestApprovals.h:16:8: warning: 'DocTestApprovalListener' has a base 'doctest::{anonymous}::ConsoleReporter' whose type uses the anonymous namespace [-Wsubobject-linkage]
[ 66%] Linking CXX executable ApprovalTests_DocTest_Tests.exe
[100%] Built target ApprovalTests_DocTest_Tests

  • Re-enable treating warnings as errors in ApprovalTests_DocTest_Tests/CMakeLists.txt
  • Add doctest support to all our documentation
  • Add doctest to the help message for when main is not correctly configured

from approvaltests.cpp.

claremacrae avatar claremacrae commented on June 13, 2024

This is now released!
See https://github.com/approvals/ApprovalTests.cpp/releases/tag/v.3.5.0

from approvaltests.cpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.