Comments (10)
I must admit that we haven't tested with ActiveJob yet. We'll get a testing setup for that together this week and I'll get back to you on this.
from appsignal-ruby.
Sounds good, thanks!
from appsignal-ruby.
Hello,
Is this still the case or has it been fixed since?
Thank you.
from appsignal-ruby.
It looks like this issue was caused by the way Sidekiq integrates with ActiveJob. They've now fixed this in 3.3.4:
Improved ActiveJob integration - Web UI now shows ActiveJobs in a nicer format and job logging shows the actual class name, requires Rails 4.2.2+ [#2248, #2259]
https://github.com/mperham/sidekiq/blob/master/Changes.md
Could you try that version of Sidekiq?
from appsignal-ruby.
@thijsc I will, thank you for pointing this out!
from appsignal-ruby.
It's doing the same for DelayedJob too
from appsignal-ruby.
I'm working on a Que adapter and am wondering how to fix this ActiveJob issue for it. It looks like Sidekiq and DelayedJob integrate with ActiveJob for display purposes, if I'm reading the appsignal source correctly, but how to do that for ActiveJob backends that don't have this feature?
cls = args.last['job_class'] if cls == "ActiveJob::QueueAdapters::QueAdapter::JobWrapper"
in an integration might work, but I wonder how a more general solution would look like.
Also, ideally I'd like to see the actual ActiveJob info in the action arguments (incl. a mention of the JobWrapper class), but have Appsignal split jobs by ActiveJob's class name. Not sure how that would fit in, though.
from appsignal-ruby.
Hi @wvengen do you have an example/code of your Que adapter? I can take a look and see how best to support AppSigal for it :)
from appsignal-ruby.
@matsimitsu sure, feel free to participate in #70. Thanks!
from appsignal-ruby.
We've greatly improved the ActiveJob integration in 1.1, which is now in beta. Could you try that version @rnaud?
from appsignal-ruby.
Related Issues (20)
- Fix Sidekiq 7.1 error handler deprecation HOT 1
- Add support for SolidCache HOT 2
- Add support for Solid Queue HOT 8
- Sidekiq minutely probe reports error
- Support nested exceptions HOT 12
- Allow to build custom_data sample data HOT 2
- Use thread-local variables instead of fiber-local variables to store global configuration HOT 1
- Extension fails to load under Alpine Linux 3.19 HOT 1
- Diagnose report fails to send `mkmf.log`
- Appsignal logger causes sidekiq to crash HOT 2
- Log not being rotated HOT 5
- Rename internal logger
- The request header REQUEST_URI contains PII or secrets that should be stripped via filter_parameters HOT 4
- Typo in Changelog HOT 1
- Report activejob errors only when the job is discarded HOT 2
- Rails.error.report is missing information compared to Appsignal.set_error HOT 9
- Cron heartbeats support HOT 3
- AppSignal Agent crashes and stops logging: No longer owner of lock file '/tmp/appsignal/agent.lock', agent exiting HOT 2
- Allow sending custom_data via the Rails error reporter
- Error in STDOUT about unable to log sql events HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from appsignal-ruby.