Giter VIP home page Giter VIP logo

Comments (10)

thijsc avatar thijsc commented on June 8, 2024

I must admit that we haven't tested with ActiveJob yet. We'll get a testing setup for that together this week and I'll get back to you on this.

from appsignal-ruby.

rnaud avatar rnaud commented on June 8, 2024

Sounds good, thanks!

from appsignal-ruby.

fwl avatar fwl commented on June 8, 2024

Hello,

Is this still the case or has it been fixed since?

Thank you.

from appsignal-ruby.

thijsc avatar thijsc commented on June 8, 2024

It looks like this issue was caused by the way Sidekiq integrates with ActiveJob. They've now fixed this in 3.3.4:

Improved ActiveJob integration - Web UI now shows ActiveJobs in a nicer format and job logging shows the actual class name, requires Rails 4.2.2+ [#2248, #2259]

https://github.com/mperham/sidekiq/blob/master/Changes.md

Could you try that version of Sidekiq?

from appsignal-ruby.

fwl avatar fwl commented on June 8, 2024

@thijsc I will, thank you for pointing this out!

from appsignal-ruby.

scottrobertson avatar scottrobertson commented on June 8, 2024

It's doing the same for DelayedJob too

from appsignal-ruby.

wvengen avatar wvengen commented on June 8, 2024

I'm working on a Que adapter and am wondering how to fix this ActiveJob issue for it. It looks like Sidekiq and DelayedJob integrate with ActiveJob for display purposes, if I'm reading the appsignal source correctly, but how to do that for ActiveJob backends that don't have this feature?

cls = args.last['job_class'] if cls == "ActiveJob::QueueAdapters::QueAdapter::JobWrapper"

in an integration might work, but I wonder how a more general solution would look like.

Also, ideally I'd like to see the actual ActiveJob info in the action arguments (incl. a mention of the JobWrapper class), but have Appsignal split jobs by ActiveJob's class name. Not sure how that would fit in, though.

from appsignal-ruby.

matsimitsu avatar matsimitsu commented on June 8, 2024

Hi @wvengen do you have an example/code of your Que adapter? I can take a look and see how best to support AppSigal for it :)

from appsignal-ruby.

wvengen avatar wvengen commented on June 8, 2024

@matsimitsu sure, feel free to participate in #70. Thanks!

from appsignal-ruby.

thijsc avatar thijsc commented on June 8, 2024

We've greatly improved the ActiveJob integration in 1.1, which is now in beta. Could you try that version @rnaud?

from appsignal-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.