Crash when add over 4000 source file to xcode project about xcodeeditor HOT 10 CLOSED

Hi! I would say it needs some auto-release pools.

I'd love to jump straight on this, however I'm running late with some client work.

from xcodeeditor.

I already added auto-release pool at begin adding and project save method.
But it still keep end my application

from xcodeeditor.

• Also need to make sure there's no leak.
• If you don't need to support 32 bit environments we could convert to ARC. (The project used to be ARC but was backported to manual memory to support 32bit OSX). . .. (this still might not fix a leak, especially if its due to a retain cycle).
• Otherwise, we could profile in Instruments to find out what is using a lot of RAM. . I can't think of anything in the project that would be really memory hungry, except perhaps the contents of the files. . . (Even that not so much compared to say an image, video, etc). .. . based on this maybe it is in fact a leak, and not an inefficiency?

from xcodeeditor.

Did you try running the clang static analyzer?

from xcodeeditor.

It appears that when adding many files, most of the memory is stored in the _members variable on XCGroup. Each time it adds another file, the _members array gets recreated from the calls:

XCGroup addClass:
XCGroup makeGroupMemberWithName:contents:type:fileOperationStyle:
XCGroup memberWithDisplayName:
XCGroup members

The _members array is the populated with an amount of XCSource file objects proportional to how many you have already added in a tight loop.

Now before the next iteration of the loops runs, the _members array is correctly released when XCGroup flagMembersAsDirty is called at the end of the addMemberWithKey: method.

However, the objects in the _members array are all autoreleased, so they will not be released immediately.

Without changing the library, you can wrap your loop with:

NSAutoreleasePool * pool = [[NSAutoreleasePool alloc] init];

and

[pool drain];

which seems to fix this problem for me.

I've pushed changing the members method of XCGroup so that the objects added to the _members array are created within an autorelease pool.

from xcodeeditor.

@CnCool You LEGEND! Great work.

@mthuong - Please confirm fixed?

from xcodeeditor.

I am checking. Will be back soon :)

Sent from Thuong Nguyen's iPhone

On Nov 7, 2013, at 6:36 PM, Jasper Blues [email protected] wrote:

@CnCool https://github.com/cncool You LEGEND! Great work.

@mthuong https://github.com/mthuong - Please confirm fixed?

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/29#issuecomment-27955830
.

from xcodeeditor.

Thanks for your help! It was fixed! 💃

from xcodeeditor.

Thanks again @CnCool! (Connor Duggan).

How are you installing the library? I'll go ahead and push a new version to CocoaPods

from xcodeeditor.

Pushed 1.6 to CoocoaPods

from xcodeeditor.