Problems with composer update about laravel-options HOT 10 CLOSED

Hi @pwronline,

I can't reproduce this issue when:

1. New Laravel 5.7.* project
2. Composer require appstract/laravel-options
3. Composer update

I expected your error in step 3, but it didn't show up. Maybe it's a conflict with one of the other packages?

from laravel-options.

Hi @teuunn,

your \Appstract\Option::delete method should be compatible with \Illuminate\Database\Eloquent\Model::delete (yours have an $key attribute). It's not a good idea to override Eloquents methods - use model events instead.

from laravel-options.

@teuunn Getting this error too with 1.1.0

from laravel-options.

Hi @htulibacki

Definitely the way I would take when building something new. For now maybe a quick fix can eliminate the issue

from laravel-options.

Hi @wassim, do you have an example to reproduce the issue?

PR's are welcome too.

from laravel-options.

@teuunn #15 addresses the issue (changing delete -> deleteKey)
the issue was introduced here #13

from laravel-options.

I think we need to think about all method names then. It's not really consistent if the delete method is called deleteKey (with -Key) and all other methods don't have the -Key in the method name.

Maybe an idea to rename the delete method to remove or destroy?

from laravel-options.

changed it to remove @gizburdt

from laravel-options.

Thanks, will have a look at later :)

from laravel-options.

Merged and tagged v2.0.0

from laravel-options.