Giter VIP home page Giter VIP logo

Comments (5)

0xGabi avatar 0xGabi commented on August 28, 2024 1

@sohkai Yes it does. And the default value of the --files flag is . so all files are included. Using manifest.json instead we only include the relevant information for templates. Btw this is something I been thinking to improve for the publish workflow

from deployments.

sohkai avatar sohkai commented on August 28, 2024 1

I think we had decided at one point earlier that we shouldn't enforce the manifest.json as part of the publishing process, but if it's present, I think it would be reasonable to include always include it (similar to the built artifact.json).

However, that does bring up the question of if there's a way for a user to specify that they don't want any other files to be published.

from deployments.

sohkai avatar sohkai commented on August 28, 2024 1

This has been done as part of the 0.8 release.

from deployments.

0xGabi avatar 0xGabi commented on August 28, 2024

In a similar fashion should we deploy dao-templates only with the manifest.json?

aragon apm publish patch --files manifest.json

from deployments.

sohkai avatar sohkai commented on August 28, 2024

@0xGabi does the CLI not include the manifest.json file by default? But yes, we should minimize the IPFS files as much as possible.

from deployments.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.