Better tenant-specific assets about tenancy HOT 4 CLOSED

That's a good point, I'll add something like that to docs.

from tenancy.

storage_path() is fixed now, but asset() is problematic.

asset("storage/images/products/$product_id.png");

This shows that any tenant can access any other tenant's files in the public storage. Therefore, a controller is likely necessary. Changing the symlink wouldn't work because there would be issues if two users were connected to two different tenant sites at the same time.

from tenancy.

Using a controller fixes the issue, but consider this: if one of these assets is the tenant's logo, now you require to call that controller also when the logo is requested, which will be at least one time on the page! This means that the whole app will run at least twice, one for the requested controller, and another for the logo itself! Which I think isn't efficient.

My solution is to separate files like this into a global (public) disk, where "logos" (in this scenario) is stored all together, and each tenant's logo is requested by its id.

		/**
		 * @return string
		 */
		public static function logo(){
			return \Storage::disk('app-public')->url('tenants/logos/' . tenant()->id . '.png');
		}

What do you think?

from tenancy.

stancl/tenancy-docs@cffbb8d

from tenancy.