Generate invalid link when heading contains underscore `_` about markdown-toc HOT 3 CLOSED

Here is a fix: turn punctuation (except _) to -, then remove consecutive, leading or trailing -

(defun markdown-toc--to-link (title count)
  "Given a TITLE, return the markdown link associated."
  (format "[%s](#%s%s)" title
          (->> title
               downcase
               (replace-regexp-in-string "[^_[:alnum:]]" "-")
               (replace-regexp-in-string "-+" "-")
               (replace-regexp-in-string "^-" "")
               (replace-regexp-in-string "-$" ""))
          (if (> count 0)
            (concat "-" (number-to-string count))
            "")))

from markdown-toc.

Hello,

Thanks for the report and the proposal fix.

I don't think deal with the leading or trailing _ are needed though.

This can be seen as typos. And the author can simply remove those.

Cheers,

from markdown-toc.

@ardumont there may be legitimate reasons for a title to start with underscore. Eg someone is documenting some system variables or functions...

If github removes it, so should you

from markdown-toc.