Confusing operand name and resource references in codebase about argo-rollouts-manager HOT 4 CLOSED

Nice suggestion, Makes total sense :). As a coincidence I got the same feedback from Leo and Zack(Maintainers of Argo Rollouts).

A small change to your suggestion of the name, I think rollouts-manager will sound more appropriate custom resource name.

from argo-rollouts-manager.

Regarding the below points

    `reconccileRolloutsControllerService` vs `reconcileRolloutsService` (and associated comments and log messages)
    `reconcileRolloutsControllerRole` vs `reconcileRolloutsRole`

I don't think we should change the names of these methods as they are correct. We are actually reconciling the Rollouts Role and not Rollouts Controller Role.

from argo-rollouts-manager.

Regarding the below points

reconccileRolloutsControllerService vs reconcileRolloutsService (and associated comments and log messages)
reconcileRolloutsControllerRole vs reconcileRolloutsRole

I don't think we should change the names of these methods as they are correct. We are actually reconciling the
Rollouts Role and not Rollouts Controller Role.

The purpose of this role is to reconcile rollouts, but rollouts is a resource though, it wouldn't have a serviceaccount of its own, right?
I just meant that the role is associated to the controller's serviceaccount so we should call the function that

from argo-rollouts-manager.

Read through the description and comments, and it appears all issues have been addressed.

from argo-rollouts-manager.