Comments (3)
Interesting idea, not sure if it fits together with the ignore selector feature. What is the nature of the difference, and why wouldn't the ignore feature solve your problem?
@lazytesting what do you think of it?
from argus-eyes.
But then by the same logic would imply you never need a threshold function? I don't understand how it can be considered useful globally but not per-component. Nor how it conflicts with the option to hide certain selectors.
I would prefer to set a threshold per/component rather than ignore selectors completely. In some cases we still want to check that something is displaying and in the correct position, even if the content may itself change.
from argus-eyes.
@rarkins you have a point, it makes sense to be able to set this on component level.
Let's make it configurable on the following levels:
- base config
- page
- component
If it's set on multiple levels we use the highest value. This allows you to set a base threshold and use a higher value on a specific page or component.
With this change we should remove the CLI option, as the CLI arguments should be used for environment specific settings only.
from argus-eyes.
Related Issues (20)
- Move screenshot cropping outside PhantomJS HOT 2
- Feature: running screenshots parallel HOT 5
- multi level finished-when HOT 2
- Session / authenticated access HOT 2
- Phantom Flags HOT 2
- possibility to use relative urls
- hi, how does this tools set cookies ? HOT 2
- Credentials issue HOT 7
- Avoiding false negatives with comparing HOT 3
- Support configurable PhantomJS timeout HOT 4
- [ENOENT] Screenshot not found in right side
- Ignore selectors should match multiple
- Difference of 0%
- Replace images with placeholders rather than `display:none`
- Add support for different headless browsers
- Unable to clip component 'google search' timed out HOT 13
- How to change user-agent ?
- Refactor out mock-server for npm module http-server HOT 1
- Generate html overview HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from argus-eyes.