Giter VIP home page Giter VIP logo

Comments (9)

arjenhiemstra avatar arjenhiemstra commented on August 15, 2024 1

Thanks for the suggestion, I'll have a look at it (always welcome to put it in a PR as well :))

All values are transmitted, but only in one entity that is added to HA: the fan. Based on the code it also can send discovery messages for temperature and humidity so they are added as an entity, but that doesn't happen right now (with firmware readout).

Ah, I misunderstood what you meant, you are correct, this is a bug!

from ithowifi.

arjenhiemstra avatar arjenhiemstra commented on August 15, 2024

The code transitioned somewhat from first reading out the original sensor directly (that was unstable), providing an alternative sensor that could not be read from by the itho firmware (or could be built into older itho models that did not have the hum sensor option available) to the ability to readout the values directly from the itho firmware.

The first option enables/disables direct readout of the sensor via I2C (original or alternative)
The second option disables the sensor in itho firmware, this is needed if an original sensor is being read via I2C in order to prevent crashes of the itho firmware (only relevant for newer itho models).
The readout of values out of the itho firmware has been added since the latest version and is fully automatic, non invasive and now probably the best option for itho units that have the sensor built in by default. Unless you don't want the itho firmware to react on hum input from the unit itself but you want to measure the values and determine the itho speed, in that case you still could use the first two options.

The warnings about enabling the first option (reading) without enabling the second option (block support in Itho firmware) no longer apply if I've correctly read the discussions, so they can be removed.

The combination of settings thus depends on your itho model, which sensor (original/alternative) you want to use and how you want to read the sensor. Both options are still needed to make this possible.

In MQTT settings, enabling Home Assistant MQTT Discovery only seems to send out a message for the fan even though humidity/temperature

All detected values are automatically transmitted to HA after enabling auto discovery, this (should) include any detected temp / hum values.
In my case it looks like this:
image

from ithowifi.

jpelgrom avatar jpelgrom commented on August 15, 2024

Thanks for the clarification. Looks like I mixed up 'built-in sensor' with 'itho original sensor', as 'built-in' is just any sensor plugged into the board. The options don't explicitly mention this is for I2C readout instead of the (default) firmware readout, which makes it all quite confusing when you have an original sensor which can be read without enabling any of the options.

Is there any reason to still use I2C readout with an original sensor and when you only want the data / the box is allowed to react to humidity changes? If not, perhaps it would be better to change to two simple questions and adjust the settings based on that:

  • Which type of sensor do you have: no sensor, itho original or alternative?
  • Do you want the box to react to humidity changes? (right now only required in case question 1 is answered with 'itho original', perhaps also for alternative if #23 is implemented)

That allows you to keep the options shown to users the same regardless of model/hardware, but have a different implementation. Based on the answers you could then set the actual options:

no sensor itho original alternative
allow reaction to humidity change (get data only) n/a, both off support off, disable in firmware off
(firmware readout)
support on, disable in firmware off
(I2C readout, reaction not possible)
don't allow reaction to humidity change n/a, both off support on, disable in firmware on
(I2C readout)
support on, disable in firmware off (I2C readout)

This doesn't allow you to disable readout completely but if a sensor is installed I see no reason to do so. Also assuming people don't plug an original sensor in to an older itho box :)

All detected values are automatically transmitted to HA after enabling auto discovery, this (should) include any detected temp / hum values.

All values are transmitted, but only in one entity that is added to HA: the fan. Based on the code it also can send discovery messages for temperature and humidity so they are added as an entity, but that doesn't happen right now (with firmware readout).

from ithowifi.

arjenhiemstra avatar arjenhiemstra commented on August 15, 2024

Thinking about it a bit longer, probably I could bring it down to just one setting:
if sensor readout is turned on:
if itho HW version = 25 or 27 & original sensor => disable sensor support in the itho firmware
otherwise only activate sensor readout

from ithowifi.

jpelgrom avatar jpelgrom commented on August 15, 2024

If you can automatically detect the sensor that's plugged in and whether they're supported in firmware, you could indeed only show a setting to disable firmware support for the original sensor + fw that support it. That sounds tricky though, since as I understand it you can only check on power on and you need to know whether or not you get a sensor readout both via firmware and via I2C?

from ithowifi.

arjenhiemstra avatar arjenhiemstra commented on August 15, 2024

All requests are currently also done through I2C so that's no difference. How to error handle faulty readouts etc. is indeed the most important thing to work out.

from ithowifi.

arjenhiemstra avatar arjenhiemstra commented on August 15, 2024

issue should be solved with 7502b35
Please test if this is working as expected

from ithowifi.

jpelgrom avatar jpelgrom commented on August 15, 2024

Home Assistant immediately picked up the humidity and temperature after updating, so it appears to be working!

Updated setting also looks like an improvement, that was a quick update, thanks!

from ithowifi.

arjenhiemstra avatar arjenhiemstra commented on August 15, 2024

Great! Thanks for creating this issue and for the testing!

from ithowifi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.