Feature request - WPU heat-pump support about ithowifi HOT 123 CLOSED

I installed the latest version and it look ok. All values seem more or less logical.
Result: 80 82 A4 00 01 6F 92 92 92 92 92 92 92 92 92 92 92 92 92 92 0C 0C 0C 0C 10 10 0C 00 00 00 10 10 0C 0C 0C 0C 0C 10 92 92 00 00 00 00 92 92 92 92 00 00 10 0C 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 12 00 00 20 00 00 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 00 00 00 A2 A5 92 92 90 10 00 00 00 00 10 ED
Status:
Result: 80 82 A4 01 01 AA 02 BC 13 6D 13 9E 02 8C 03 FE 1B 51 14 96 03 20 03 E2 09 1A 0A CC 00 78 01 53 00 00 00 00 00 00 00 00 05 71 00 00 45 64 05 AA 05 AA 01 00 00 01 00 01 24 08 48 08 34 00 03 06 00 02 28 16 53 02 28 16 53 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 13 00 00 00 00 00 00 00 00 00 00 08 5A 00 00 00 00 01 F4 17 00 61 94 C0 36 2D 00 00 01 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00 00 00 01 00 00 00 00 01 00 00 00 01 01 FF FF FF D0 00 6A 1C 01 1A F9 00 00 00 3C 03 B5 01 09 29 1A 00 00 A7

from ithowifi.

This is where comments in code make sense I guess ;-)

from ithowifi.

So this then should work better?

const uint8_t itho_WPUset11_17[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,98 };

const uint8_t *ithoWPUSettingsMap[] =  { nullptr, itho_WPUset2,itho_WPUset4,itho_WPUset5,itho_WPUset6,itho_WPUset7,itho_WPUset8_9,itho_WPUset10,itho_WPUset11_17,itho_WPUset11_17,itho_WPUset11_17,itho_WPUset11_17,itho_WPUset11_17,itho_WPUset11_17,itho_WPUset18_19,itho_WPUset20,itho_WPUset21,itho_WPUset22,itho_WPUset23,itho_WPUset24,itho_WPUset25,itho_WPUset27,itho_WPUset31,itho_WPUset33,itho_WPUset34,itho_WPUset37};

Will tidy up the rest as well with some scripting.

from ithowifi.

__FlashStringHelper is a wrapper class defined here:
https://github.com/espressif/arduino-esp32/blob/b94b38c9d11f3c4a85ac3e18a9ec22132351716d/cores/esp32/WString.h#L38

wpu.h or IthoSystemConstant.h are both fine, I'll pull the PR to a local dirty branch and test/compile the code. I can post the compiled version here

from ithowifi.

Ok, to debug this. I can start with this Query Status?

" 80 82 A4 01 01 D4 F4 48 0B 38 10 FB 01 4A 03 6B 10 A1 09 BD 02 1A 03 50 09 8D 08 6A 00 E9 01 17 00 00 00 00 00 00 00 05 5A 00 5A 3D 00 00 00 01 00 00 01 00 01 F4 08 0E 08 66 64 02 07 00 01 18 0A 45 01 18 0A 45 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 09 00 00 00 00 00 00 00 00 00 00 00 00 2A 30 00 00 01 F4 20 00 5A 94 ED D3 2D 00 01 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00 00 00 00 01 00 00 00 01 00 00 00 64 00 00 00 05 00 00 04 29 00 00 00 C5 00 00 00 56 00 01 27 10 00 06 63 00 00 00 00 F5 10 00 96 00 02 1A 05 78 3D 00 00 FF 00 00 00 00 0E 10 00 00 00 00 05 A0 00 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 C7"

I saw 1065 displayed as CV pressure which translates to 04 29 in hex and values are separated by 00? But will have a better look at your code this evening

Ah nvm, you explained it already.

from ithowifi.

Ah, that explains! The array index = itho version
So version 34 would translate to the pointer at *ithoWPUSstatusMap[34].

So the array must be something like this:
const uint8_t *ithoWPUSstatusMap[] = { nullptr,nullptr,itho_WPUstatus2,nullptr,itho_WPUstatus4, itho_WPUstatus5, itho_WPUstatus6, itho_WPUstatus7, itho_WPUstatus8_9, itho_WPUstatus8_9, itho_WPUstatus10, itho_WPUstatus11_17, itho_WPUstatus11_17, itho_WPUstatus11_17, itho_WPUstatus11_17, itho_WPUstatus11_17, itho_WPUstatus11_17, itho_WPUstatus11_17, itho_WPUstatus18_19, itho_WPUstatus18_19, itho_WPUstatus20, itho_WPUstatus21, itho_WPUstatus22_25, itho_WPUstatus22_25, itho_WPUstatus22_25, itho_WPUstatus22_25,nullptr, itho_WPUstatus27,nullptr,nullptr,nullptr, itho_WPUstatus31,nullptr, itho_WPUstatus33, itho_WPUstatus34_37, itho_WPUstatus34_37, itho_WPUstatus34_37, itho_WPUstatus34_37};

from ithowifi.

Everything else looks good OK now. Havent seen anything that looks completely off.

Some suggestions for next versions:

1. Add unit type (I can read it from Itho dbase and add it to the label) as otherwise it's difficult to interpret the values
2. Selection of fields for MQTT?
   I guess out of all status values available, not everything is interesting for a HA system. MQTT supports the large message size all together and filtering can be done on receiving end, but sending a select number of fields feels cleaner.

from ithowifi.

Thanks, I was trying to load the data via MQTT in Home Assistant but it seems there's another fix needed?

This is not relevant anymore?

No, It was my fault. I didn’t turn on mqtt with the new firmware so initially looked at the old mqtt from the previous version. Rookie mistake

from ithowifi.

So much for the theory of full overlap then....

Having a per version all labels explicitly added to the .h file will just add bloat and just adding a baseline (v37) with per versions differences only is difficult I guess.

Having a per version all labels explicitly added to the .h file is not needed. What I did up until now was create one list with all the unique labels for all the different versions, this creates the flashstring array with all the possible labels. Then map it to the correct index position for a particular version. Where the mapping is the same between versions they are collapsed into one mapping.
So it seems that the only change needed to the script is that the total mapping is created for each version instead of assuming that parts of the mapping always overlap.

from ithowifi.

Spaghetti code incoming. Had to rewrite it quite a few times to have the squashing done based on versions / record count.
I think the only part that's still relevant are the labels and not the structs anymore given your changes earlier and I didn't update that part.

class ExportWPU 
                
{                       
        private $db;    
                        
                        
        public function __construct() 
        {                               
                $this->db = new SQLite3('wpu.db');
        }                               
                                
        private function squashcounts(array $d): array
        {                       
                $output = [];
                $tmp = [];
                $tmpCount = [];
                foreach($d as $k=>$v) {
                        if (count($v) > 1)      {
                                $output[$k] = $v;
                        } else {
                                $results = $this->db->query("select count(*) as cnt from datalabel_v".$v[0]);
                                $row = $results->fetchArray();
                                $tmp[$v[0]] = $row[0];
                                if (! isset($tmpCount[$row[0]])) {
                                        $tmpCount[$row[0]] = [];
                                }
                                $tmpCount[$row[0]][] = $v[0];
                        }       
                }               
                                        
                foreach($tmpCount as $count=>$v) 
                {                       
                        if (count($v) == 1) {
                                $output[$v[0]][] = $v[0];
                        } else {        
                                $output[$v[0]] = $v;
                        }       
                }       
                ksort($output);
        
                return $output;
        }

        public function squashSettings(): void
        {
                $results = $this->db->query("select version,datalabel from versiebeheer");
                $v = [];
                while ($row = $results->fetchArray()) {
                        $v[$row['version']] = $row['datalabel'];
                }
                $dl = [];
                foreach($v as $key=>$value) {
                        if (! isset($dl[$value])) { $dl[$value] = []; }

                        $dl[$value][] = $key;
                }

                $dl = $this->squashcounts($dl);

                $settings = [];
                foreach($dl as $k=>$v) {
                        $av = array_values($v);
                        if (count($v) == 1) {
                                echo "const uint8_t itho_WPUset".$k."[] = { ".$this->getStatusByVersion($k)."};\n";

                                $settings[$av[0]] = "itho_WPUset".$k;

                        } else {
                                $c = count($v);
                                $from = array_shift($v);
                                $to = array_pop($v);
                                echo "const uint8_t itho_WPUset".$from."_".$to."[] = { ".$this->getStatusByVersion($k)." };\n";
                                for($i=0;$i<$c;$i++) {
                                        $settings[$from+$i] = "itho_WPUset".$from."_".$to;
                                }
                        //      $settings[$v] = "WPUset".$from."_".$to; 
                        }
                }
                echo "\n\n";
                echo "const uint8_t *ithoWPUSettingsMap[] =  { nullptr, ";
                foreach($settings as $version => $code) {
                        echo $code.",";
                }
                echo "255};\n\n";

        }

        public function squashStatus(): void
        {
                $results = $this->db->query("select version,datalabel from versiebeheer");
                $v = [];
                while ($row = $results->fetchArray()) {
                        $v[$row['version']] = $row['datalabel'];
                }
                $dl = [];
                foreach($v as $key=>$value) {
                        if (! isset($dl[$value])) { $dl[$value] = []; }
                        $dl[$value][] = $key;
                }

                $settings = [];
                $dl = $this->squashcounts($dl);
                foreach($dl as $k=>$v) {
                        $av = array_values($v);
                        if (count($v) == 1) {
                                echo "const uint8_t itho_WPUstatus".$k."[] = { ".$this->getStatusByVersion($k)."};\n";

                                $settings[$av[0]] = "itho_WPUstatus".$k;

                        } else {
                                $c = count($v);
                                $from = array_shift($v);
                                $to = array_pop($v);

                                echo "const uint8_t itho_WPUstatus".$from."_".$to."[] = { ".$this->getStatusByVersion($k)." };\n";
                                for($i=0;$i<$c;$i++) {
                                        $settings[$from+$i] = "itho_WPUstatus".$from."_".$to;
                                }
                        }
                }
                echo "\n\n";
                echo "const uint8_t *ithoWPUSstatusMap[] =  { nullptr, ";
                foreach($settings as $version => $code) {
                        echo $code.",";
                }
                echo "255};\n\n";

        }



        private function getStatusByVersion(int $version): string
        {
                $results = $this->db->query("select id from datalabel_v".$version);
                $rv = [];
                while ($row = $results->fetchArray()) {
                        $rv[] = $row['id'];
                }
                return join(",",$rv);
        }

        public function createSettingDescriptions(): void
        {
                echo "const __FlashStringHelper *ithoWPUSettingDescriptions[] = {\n";


                $results = $this->db->query("SELECT * from versiebeheer where datalabel = '37'");
                while ($row = $results->fetchArray()) {
                        $v = $row['datalabel'];
                        $q = "select title,tooltip from datalabel_v".$v;
                        $rq = $this->db->query($q);
                        while ($r2 = $rq->fetchArray()) {
                                if (! empty($r2['tooltip'])) {
                                        $labels = $r2['tooltip'];
                                } else {
                                        $labels = $r2['title'];
                                }
                                echo 'F("'.$labels.'"),';
                                echo "\n";
                        }
                }

                echo "\n};\n\n";

        }

        public function createStatusLabels(): void
        {
                echo "const __FlashStringHelper *ithoWPUStatusLabels[] =  {\n";
                        $results = $this->db->query("SELECT * from versiebeheer where datalabel = '37'");
                        while ($row = $results->fetchArray()) {
                                $v = $row['datalabel'];
                                $q = "select title,unit from datalabel_v".$v;
                                $rq = $this->db->query($q);
                                while ($r2 = $rq->fetchArray()) {
                                        $labels = $r2['title'];
                                        if ($r2['unit'] != '') {
                                        echo 'F("'.$labels.' ('.$r2['unit'].')"),';
                                        } else {
                                                echo 'F("'.$labels.'"),';
                                        }
                                        echo "\n";
                                }
                        }
                echo "\n};\n\n";


}



$w = new ExportWPU;
$w->squashSettings();
$w->squashStatus();
$w->createStatusLabels();
$w->createSettingDescriptions();

?>

from ithowifi.

Hmm, Arjen beat me to it. :)

Some coding to get for each name (regardless of the version) the matching versions, not considering squashing (yet).

1. Build an array with unique labels across all versions using name
2. Iterate over all versions and create an array of label positions
3. Show title + unit

const uint8_t itho_WPUstatus2[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60 }
const uint8_t itho_WPUstatus4[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67 }
const uint8_t itho_WPUstatus5[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,68 }
const uint8_t itho_WPUstatus6[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,69,70,64,65,66,67,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97 }
const uint8_t itho_WPUstatus7[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,98,99,100,45,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,69,70,64,101,66,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,102 }
const uint8_t itho_WPUstatus8[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,98,99,100,45,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,69,70,64,101,66,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,102,103 }
const uint8_t itho_WPUstatus10[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,104,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,98,99,100,45,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,69,70,64,101,66,71,72,73,74,75,76,77,78,79,80,105,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,102,103 }
const uint8_t itho_WPUstatus11[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,104,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,106,107,98,99,100,45,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,69,70,108,109,110,64,101,66,71,72,73,74,75,76,77,78,79,80,105,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,102,103 }
const uint8_t itho_WPUstatus18[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,104,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,106,107,98,99,100,45,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,69,70,108,109,110,64,101,66,71,72,73,74,75,76,77,78,79,80,105,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,111,102,103,112,113,114,115,116,117,118,119,120,121 }
const uint8_t itho_WPUstatus20[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,104,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,106,107,98,99,100,45,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,69,70,108,109,110,64,101,66,71,72,73,74,75,76,77,78,79,80,105,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,111,102,103,112,113,114,115,116,117,118,119,120,121,122 }
const uint8_t itho_WPUstatus21[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,104,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,106,107,98,99,100,45,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,69,70,108,109,110,64,101,66,71,72,73,74,75,76,77,78,79,80,105,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,111,102,103,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127,128,129,130,131,132,133 }
const uint8_t itho_WPUstatus22[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,104,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,106,107,98,99,100,45,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,69,70,108,109,110,64,101,66,71,72,73,74,75,76,77,78,79,80,105,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,111,102,103,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127,128,129,130,131,132,133,134 }
const uint8_t itho_WPUstatus23[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,104,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,106,107,98,99,100,45,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,69,70,108,109,110,64,101,66,71,72,73,74,75,76,77,78,79,80,105,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,111,102,103,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127,128,129,130,131,132,133,134 }
const uint8_t itho_WPUstatus24[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,104,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,106,107,98,99,100,45,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,69,70,108,109,110,64,101,66,71,72,73,74,75,76,77,78,79,80,105,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,111,102,103,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127,128,129,130,131,132,133,134 }
const uint8_t itho_WPUstatus25[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,104,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,106,107,98,99,100,45,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,69,70,108,109,110,64,101,66,71,72,73,74,75,76,77,78,79,80,105,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,111,102,103,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127,128,129,130,131,132,133,134 }
const uint8_t itho_WPUstatus27[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,104,135,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,106,107,98,99,100,45,47,48,49,50,51,52,54,53,55,56,57,58,59,60,61,69,70,108,109,110,64,101,66,71,72,73,74,75,76,77,78,79,80,105,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,111,136,137,138,139,102,103,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127,128,129,130,131,132,133,134,140,141,142 }
const uint8_t itho_WPUstatus31[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,104,135,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,106,107,98,99,100,45,47,48,49,50,51,52,54,53,55,56,57,58,59,60,61,69,70,108,109,110,64,101,66,71,72,73,74,75,76,77,78,79,80,105,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,111,136,137,138,139,143,103,114,115,116,122,123,124,125,126,127,128,129,130,131,132,134,140,141,142,144,145,146,102 }
const uint8_t itho_WPUstatus33[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,104,135,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,106,107,98,99,100,45,47,48,49,50,51,52,54,53,55,56,57,58,59,60,61,69,70,108,109,110,64,101,66,71,72,73,74,75,76,77,78,79,80,105,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,111,136,137,138,139,143,103,114,115,116,122,123,124,125,126,127,128,129,147,131,130,132,134,140,141,142,144,145,146,102,148,149,150,151,152,153 }
const uint8_t itho_WPUstatus34[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,104,135,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,106,107,98,99,100,45,47,48,49,50,51,52,54,53,55,56,57,58,59,60,61,69,70,108,109,110,64,101,66,71,72,73,74,75,76,77,78,79,80,105,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,111,136,137,138,139,143,103,114,115,116,122,123,124,125,126,127,128,129,147,131,130,132,134,140,141,142,144,145,146,102,148,149,150,151,152,153,154 }
const uint8_t itho_WPUstatus37[] = { 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,104,155,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,106,107,98,99,100,45,47,48,49,50,51,52,54,53,55,56,57,58,59,60,61,69,70,108,109,110,64,101,66,71,72,73,74,75,76,77,78,79,80,105,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,111,136,137,138,139,143,103,114,115,116,122,123,124,125,126,127,128,129,147,131,130,132,134,140,141,142,144,145,146,102,148,149,150,151,152,153,154 }

Flash labels:

F(|0|"Buitentemp (°C)"),
F(|1|"Boiler laag (°C)"),
F(|2|"Boiler hoog (°C)"),
F(|3|"Verdamper temp (°C)"),
F(|4|"Zuiggas temp (°C)"),
F(|5|"Persgas temp (°C)"),
F(|6|"Vloeistof temp (°C)"),
F(|7|"Naar bron (°C)"),
F(|8|"Van bron (°C)"),
F(|9|"CV aanvoer (°C)"),
F(|10|"CV retour (°C)"),
F(|11|"Druksensor (Bar)"),
F(|12|"Stroomtrafo 1 (A)"),
F(|13|"Stroomtrafo 2 (A)"),
F(|14|"Drukschakelaar"),
F(|15|"Hoog / laag"),
F(|16|"Condens beveiliging"),
F(|17|"Pulsteller"),
F(|18|"Flowsensor (lt/hr)"),
F(|19|"Fase detectie"),
F(|20|"Cv pomp (%)"),
F(|21|"Bron pomp (%)"),
F(|22|"Boiler pomp (%)"),
F(|23|"Vrijkoelklep (pls)"),
F(|24|"Cv klep (pls)"),
F(|25|"Compressor"),
F(|26|"Element"),
F(|27|"Trickle heating"),
F(|28|"Fout"),
F(|29|"Vrijkoel"),
F(|30|"Expansieventiel (pls)"),
F(|31|"Kamertemp (°C)"),
F(|32|"Gevr temp (°C)"),
F(|33|"Vraag (%)"),
F(|34|"State"),
F(|35|"Sub_status"),
F(|36|"Blokkade"),
F(|37|"Berekende verdampings temp (°C)"),
F(|38|"Berekende condensatie temp (°C)"),
F(|39|"Foutcode byte 5"),
F(|40|"Foutcode byte 4"),
F(|41|"Foutcode byte 3"),
F(|42|"Foutcode byte 2"),
F(|43|"Foutcode byte 1"),
F(|44|"Foutcode byte 0"),
F(|45|"Handbediening"),
F(|46|"Logging (sec)"),
F(|47|"Compr blok (sec)"),
F(|48|"Elek blok (sec)"),
F(|49|"Cv voor / nadraai (sec)"),
F(|50|"Bron voor / nadraai (sec)"),
F(|51|"Boiler voor / nadraai (sec)"),
F(|52|"Delay elektr (sec)"),
F(|53|"Min draaitijd compr (sec)"),
F(|54|"Afpomp tijd (sec)"),
F(|55|"EV drukvereffenen (sec)"),
F(|56|"EV verstellen (sec)"),
F(|57|"Vrijkoel interval (sec)"),
F(|58|"Handbediening (sec)"),
F(|59|"Lage druk timer (sec)"),
F(|60|"Compressor start (sec)"),
F(|61|"Compr power on delay (sec)"),
F(|62|"Cv start vertraging (sec)"),
F(|63|"Cv stop vertraging (sec)"),
F(|64|"Fout hoogste prioriteit"),
F(|65|"Tijd voor fouthistorie (sec)"),
F(|66|"Max cv retour temp (°C)"),
F(|67|"StroomHardware"),
F(|68|"Fout hoogste prioriteit"),
F(|69|"Vertraging cv start (sec)"),
F(|70|"Vertraging cv stop (sec)"),
F(|71|"Bronpomp snelheid vrijkoel mode"),
F(|72|"Compressor in Cv mode"),
F(|73|"Compressor in boiler mode"),
F(|74|"Element in cv mode"),
F(|75|"Element in boiler mode"),
F(|76|"Cv mode geblokkeerd"),
F(|77|"Boiler mode geblokkeerd"),
F(|78|"Vrijkoel mode geblokkeerd"),
F(|79|"Ontlucht mode geblokkeerd"),
F(|80|"Elektr element geblokkeerd"),
F(|81|"Compressor geblokkeerd"),
F(|82|"Off mode aktief"),
F(|83|"Cv mode aktief"),
F(|84|"Boiler mode aktief"),
F(|85|"Vrijkoel mode aktief"),
F(|86|"Cv pomp voordraaien"),
F(|87|"Bron pomp voordraaien"),
F(|88|"Element vrijgegeven door gebruiker"),
F(|89|"Vrijgave extra koelen"),
F(|90|"Cv vrijgegeven"),
F(|91|"Vrijkoel vrijgegeven"),
F(|92|"Tarief laag vanuit thermostaat"),
F(|93|"Ontluchten vanuit thermostaat"),
F(|94|"Eco geselecteerd op thermostaat"),
F(|95|"Comfort geselecteerd op thermostaat"),
F(|96|"Boiler blokkade vanuit thermostaat"),
F(|97|"Boiler boost vanuit thermostaat"),
F(|98|"Fout_gevonden"),
F(|99|"Fout_retry"),
F(|100|"Taak aktief"),
F(|101|"UTC tijd"),
F(|102|"UTC tijd :"),
F(|103|"Element alleen voor DHW vrijgegeven"),
F(|104|"Spare Ingang"),
F(|105|"Elektr Element DHW geblokkeerd"),
F(|106|"Berekende verdampings temp DHW (°C)"),
F(|107|"Berekende condensatie temp DHW (°C)"),
F(|108|"Adaptief timer (sec)"),
F(|109|"Adaptief oververhitting (K)"),
F(|110|"Adaptief fifo index"),
F(|111|"Warmtevraag (%)"),
F(|112|"P fout bronflow"),
F(|113|"I fout bronflow"),
F(|114|"PI bronflow resultaat"),
F(|115|"Actuele bronklepstand (%)"),
F(|116|"Utc Tijd offset (min.)"),
F(|117|"Gateway Tijd ontvangen"),
F(|118|"OT-tijd valid"),
F(|119|"Tijd uren (uur)"),
F(|120|"Tijd minuten (min)"),
F(|121|"Tijd seconden (sec)"),
F(|122|"Vrijkoel blokkade tijd (min.)"),
F(|123|"Vrijkoelklep control percentage (%)"),
F(|124|"Luchtklep positie (%)"),
F(|125|"HRU uitblaas temp (°C)"),
F(|126|"HRU uitblaas flow (m3/h)"),
F(|127|"Regeneratie aktief"),
F(|128|"Laatst geldige brontoevoer temp. (°C)"),
F(|129|"Bronpomp flow setpoint (l/h)"),
F(|130|"Bronpomp snelheid bij luchtreg + Compr (%)"),
F(|131|"Bronpomp snelheid bij vrijkoel (%)"),
F(|132|"Vrijkoelmodus"),
F(|133|"Vrijkoel aan tijd (sec)"),
F(|134|"Positie CO-klep (%)"),
F(|135|"Reserve"),
F(|136|"E-verbuik tijdens stand-by (kWh)"),
F(|137|"E-verbuik tijdens verwarmen (kWh)"),
F(|138|"E-verbuik tijdens DHW (kWh)"),
F(|139|"E-verbuik tijdens koelen (kWh)"),
F(|140|"Minimale vrijgave tijd extern koelen (sec.)"),
F(|141|"Blokkeertijd vrijgave extern koelen (sec.)"),
F(|142|"Blokkeertijd vrijgave extern verwarmen (sec.)"),
F(|143|"Voorverwarmen tapwater"),
F(|144|"Blokkeertijd trickle low na power-up (sec.)"),
F(|145|"Blokkeertijd trickle low na CV-bedrijf (sec.)"),
F(|146|"Blokkeertijd voorverwarmen tapwater (sec.)"),
F(|147|"Bronpomp snelheid bij Compr (%)"),
F(|148|"Slow start bronpomp (sec.)"),
F(|149|"Bron retourtemperatuur te laag (sec.)"),
F(|150|"Regelperiode bronflow (sec.)"),
F(|151|"Stabilisatie wachttijd vrijkoelen (sec.)"),
F(|152|"Minimale tijd voorverwarmen tapwater (sec)"),
F(|153|"Maximale tijd voorverwarmen tapwater (sec.)"),
F(|154|"Vrijgave elektrisch element (min)"),
F(|155|"Correctie meting delta brontemperatuur (K)")

The |XXX| is added for reference only. I am not sure if this works...

from ithowifi.

Some coding to get for each name (regardless of the version) the matching versions, not considering squashing (yet).

1. Build an array with unique labels across all versions using name
2. Iterate over all versions and create an array of label positions
3. Show title + unit

RofL! This is just brilliant. This seems to be exactly the same idea as my reply minutes earlier 💯

from ithowifi.

Thanks! The settings were just added so you couldn't have checked them earlier :)
The list is limited indeed, I've used a password level to limit the number of available settings. The total number is settings is larger than currently fits the structure and the higher password level settings are probably more dangerous and less relevant to include. Maybe at a later stage I'll include the other ones as well.

from ithowifi.

I've created a simple script that reads the WPU database of Itho and converts it to a C++ header file to get a head start.
It's here: https://github.com/jasperslits/ithowifi/blob/master/wpu.h

Oh that's nice work!! Saves me hours of manual work!

from ithowifi.

For status labels it might be a better idea to use longer names, are they available? And they need to be translated then from Dutch to English but that can be done quite easily with ie. https://www.deepl.com/translator

Also arrays that are the same could be squashed into 1, saving precious memory :)

from ithowifi.

I think the WPU devices are only used in NL but we have this for example:

130.0|FreeCoolingStabilizeTimer|Stabilisatie wachttijd vrijkoelen||sec.
131.0|PreHeatDHWMinOnTimer|Minimale tijd voorverwarmen tapwater||sec
132.0|PreHeatDHWMaxOnTimer|Maximale tijd voorverwarmen tapwater||sec.
133.0|RemainingTimeEelementReleased|Vrijgave elektrisch element||min

For preHeatDHWMinOnTimer we have the following labels available:

1. Voorverwarmen tapwater minimale aan tijd
2. Voorverwarmen tapwater is na activatie een minimale tijdsduur actief
3. Minimale tijd voorverwarmen tapwater

I guess you want to send preHeatDHWMinOnTimer in the MQTT pay load and either one of the 3 labels on the screen?
I guess nr 3 (when translated) is more user friendly then?

And today this .h file is generated by a script so if multiple versions have the same labels, they can be squashed? I can add that logic, shouldn't be rocket science (compared to what you do here) ;)

from ithowifi.

I think the WPU devices are only used in NL but we have this for example:

That might be the case, but still, I'd like to keep the interface in one language

I guess nr 3 (when translated) is more user friendly then?

Yes, sure is

Interesting to see that the repo you linked seems not to map labels based on itho fw versions, not sure if I missed something but that should not deliver the correct results in all cases.

from ithowifi.

And today this .h file is generated by a script so if multiple versions have the same labels, they can be squashed? I can add that logic, shouldn't be rocket science (compared to what you do here) ;)

Yes, the squashed label arrays can be recognised by the start and end version number ie.:

from ithowifi.

Yes, sure is

Interesting to see that the repo you linked seems not to map labels based on itho fw versions, not sure if I missed something but that should not deliver the correct results in all cases.

It does read the version from the WPU unit and then queries the database for the right labels using versiebeheer table. Each version has its own table (e.g. datalabels_v37) with some exceptions where multiple versions use the same datalabels table.

from ithowifi.

And today this .h file is generated by a script so if multiple versions have the same labels, they can be squashed? I can add that logic, shouldn't be rocket science (compared to what you do here) ;)

Yes, the squashed label arrays can be recognised by the start and end version number ie.:

ithowifi/software/NRG_itho_wifi/IthoSystemConsts.h

Line 41 in 517c84d

const uint8_t itho_DemandFlowv16_17[] {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 164, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 230, 231, 52, 53, 165, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 100, 102, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 167, 166, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 116, 117, 118, 186, 143, 144, 145, 146, 147, 149, 152, 150, 151, 184, 185, 155, 156, 157, 158, 159, 160, 180, 181, 182, 183, 161, 162, 163, 187, 188, 255};

Ah, now it makes sense. So I can adjust the naming convention. Didn't realise it was used for that squashing then

from ithowifi.

Yep, that saves memory, all those uint8_t values are loaded on the stack and thus consume memory during the lifetime of the program. Maybe it is better to write a file (or DB like system) to flash with all this info, not sure how though

from ithowifi.

I see. You don't want to put some if #defined (NON_CVE) around it? I've now a version for non-CVE and yet all other CVE values are defined and loaded?

Anyway, assume the squashed header file for settings and descriptions and Flash messages are provided. Is there anything else needed in terms of I2C output from debugging to glue to it all together?

from ithowifi.

I see. You don't want to put some if #defined (NON_CVE) around it? I've now a version for non-CVE and yet all other CVE values are defined and loaded?

For now yes, I know some users that wired the CVE version to a non-CVE device. If I can keep the memory usage acceptable I would like to keep the firmware versions as much the same as possible.

Anyway, assume the squashed header file for settings and descriptions and Flash messages are provided. Is there anything else needed in terms of I2C output from debugging to glue to it all together?

Nope, with that status and settings should work when linked to the main struct here:

All the other code should just wrap around it and work

from ithowifi.

Ok, new attempt of squashing:

https://github.com/jasperslits/ithowifi/blob/master/wpu.h

The Itho database is a bit weird: it has multiple versions pointing to the same datalabels. But it also has multiple versions with identical number of fields as others. Both are addressed.

Before spending time on the label translation, I'd like to get this tested first as part of an MVP / agile / whatever approach, just to see if the basics works.
I can send a PR for it, but not sure if you want to have it as wpu.h (as-is for readability / testing) or merged with IthoSystemConstant.h and to see if it's a good enough shape?

Unit test shows this since I don't have an Arduino IDE and just plain GNU G++ compiler:
me@playground:~/code$ g++ test.cpp

In file included from test.cpp:2:
wpu.h:41:7: error: ‘__FlashStringHelper’ does not name a type
   41 | const __FlashStringHelper *ithoWPUStatusLabels[] =  {
      |       ^~~~~~~~~~~~~~~~~~~
wpu.h:179:7: error: ‘__FlashStringHelper’ does not name a type
  179 | const __FlashStringHelper *ithoWPUSettingDescriptions[] = { 

me@playground:~/code$ cat test.cpp

#include <cstdint>
#include "wpu.h"

from ithowifi.

PR #50 is created for this

from ithowifi.

nrgitho-noncve-v2.3-beta4-wputest.bin.zip
Here's a compiled version, copied the code almost 1-on-1, only difference is that I use value 255 as a poor mans end indicator for the array so I've added these as last value in the array.

from ithowifi.

Looking at this again, it seems that both the settings labels and the status labels are both status labels. It seems that the parameters are missing

basically, only test the status page, not the settings page cause changing settings will lead to undefined behaviour

from ithowifi.

Nice!

For pameters I have to see to translate it. There's another table called 'parameterlijst_v37' which has entries like:

sqlite> select * from parameterlijst_v37 where name = 'CO control enabled';
id|name|name_factory|min|max|def|title|description|unit
6.94683340033475e-310|CO control enabled|CO control enabled|2.12199579096527e-314|2.65249473870659e-314|2.12199579096527e-314|CO-klep regeling||

So you need just the 'name' field and not the min/max values? Or is that stored somewhere too?

It's connected now and returns 80 82 90 E0 01 07 00 01 00 0D 45 22 00 11 as device type.

Query status returns:

Result: 80 82 A4 01 01 D4 F4 48 0A A6 11 F0 07 EE 08 92 08 B2 08 B6 08 03 07 76 08 46 08 61 00 AA 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 32 32 00 00 00 01 00 00 00 07 CA 07 08 00 01 FF 00 07 BC 09 2B 07 BC 09 2B 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 01 F4 09 00 5A 94 91 19 2D 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 05 00 00 04 26 00 00 00 C5 00 00 00 56 00 01 25 1C 00 06 63 00 00 32 00 F5 10 00 96 00 03 89 00 00 00 00 00 FF 00 00 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 61

Status returns this but I don't know where temp, hum and ppmw are coming from as it's not applicable?:
Some values are returned as 0 which is weird.

Can I see which version is used? Maybe there's something odd with the mapping.

Edit: looks like some values shifted. "stroom compressor" is measured in amps and a more realistic value is 5. So it looks like it's shifted a bit.

I am working on a new version of the labels and include the unit type (bar, degrees celcius, kWh etc) for the status so it's easier to validate. Mind sharing your new .h file so I can use it as a reference?

from ithowifi.

the first three are always added in the current situation.

It's connected now and returns 80 82 90 E0 01 07 00 01 00 0D 45 22 00 11 as device type.

0D 45 22
0D = device type
22 = version (34 decimal)

Latest commit contains the info you provided, don't bother translation, let's first get the code ok, I'll translate it later again

from ithowifi.

the first three are always added in the current situation.

It's connected now and returns 80 82 90 E0 01 07 00 01 00 0D 45 22 00 11 as device type.

0D 45 22 0D = device type 22 = version (34 decimal)

Latest commit contains the info you provided, don't bother translation, let's first get the code ok, I'll translate it later again

Great!
So the first 3 being added displayed doesn't cause the apparent down shift?

from ithowifi.

No, it just this piece of code:

from ithowifi.

Here the status message format command result is being parsed to determine the data length / type of the status message into a vector :

And with that info the status message itself is parsed and added to the vector created earlier:

from ithowifi.

So if the labels are not correct / or shifted, either te mapping is faulty or some cases are not handled correctly in the parsing of the status format

from ithowifi.

Ok, I am struggling a bit with debugging to see where it's coming from.

The debug page is empty and download the log (/curlog) gives a 404.
So I cannot tell if that's related as /curlog is defined:
server.on("/curlog", HTTP_GET, handleCurLogDownload);

Also the list of files is still empty when using /edit so could it be solved by a filesystem format?
It was working OK before.

I also noticed this, not sure if it's telling anything:

1. ithoWPUStatusLabels has as 20th (starting at 1) element: F("flow sensor")

However under Status I see this: "flowsensor"

So the labels there are not defined in https://github.com/arjenhiemstra/ithowifi/blob/master/software/NRG_itho_wifi/IthoSystemConsts.h

from ithowifi.

sorry, that has probably to do with the fact that I quickly added the translation yesterday but after the compilation.
Here is the compiled version of the exact same code as is now on github.
NRG_itho_wifi.ino.esp32.bin.zip

Also the list of files is still empty when using /edit so could it be solved by a filesystem format?

I did a format indeed and that solved it for me

from ithowifi.

I just realized now it's in English :)
The data is now much better it seems but seems not 100% correct.

I managed to hack the python script itho-wpu.py from Pommi and feed it with the "Query Status Format" and "Query Format" results (turning it into a hex array did the job) so it's not relying on I2C but even there the output seems not 100% reliable as -30.0 is just wrong:

Unknown data type for label In_P_switch: 0x0C
Buitentemp (°C) (t_out): -30.0
Boilertemp Onder (°C) (t_boildwn): 12.5
Boilertemp Boven (°C) (t_boiltop): 13.67
Verdamper Temp (°C) (t_evap): 11.29
Zuiggas Temp (°C) (t_suct): 19.97
Persgas Temp (°C) (t_disc): 27.07
Vloeistof Temp (°C) (t_cond): 22.3
Temp Naar Bron (°C) (t_source_r): 10.83
Temp Uit Bron (°C) (t_source_s): 18.18
Cv Aanvoertemp (°C) (t_ch_supp): 23.75
Cv Retourtemp (°C) (t_ch_ret): 20.3
Cv-Druk (Bar) (p_sens): 1.73
Stroom Compressor (A) (i_tr1): 0.0
Stroom E-Element (A) (i_tr2): 0.0
Drukschakelaar (in_p_switch): 0

Now "Boilertemp Onder" is reported at 12.5 for the Python script which makes sense.
In add-on it's returning "boiler temp below" with 0.

"CV Pressure" is reported as 1069 but I dont see anywhere the 1.73 Bar returned in the Itho Status, so even if the label was wrong. I guess it should show up?

Edit 2: it seems that the values with type 0x92 are not showing. Could that provide a clue?

from ithowifi.

The status labels are somehow not mapped correctly, left is what you have posted here, right is what should be the list if you have version 34.

ie. right your kamertemp is 21.06, sounds ok. same for the "berekende verdampings temp CV" values etc.

So it seems the status format is parsed ok (at least partly), but the status labels are not mapped correctly

from ithowifi.

The 0x92 is also part of the normal CVE status format and there it is parsed correctly. I would expect the same to happen here but there might be another reason.
Could you post the status format result as well?

from ithowifi.

So I guess there are two problems:

1. Labels in wrong order
2. Missing values (e.g. reported as 0 by the add-on

Status format: 80 82 A4 00 01 86 92 92 92 92 92 92 92 92 92 92 92 92 92 92 0C 0C 0C 0C 00 10 0C 00 00 00 00 00 0C 0C 0C 0C 0C 10 92 92 00 00 00 00 92 92 92 92 00 00 10 0C 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 12 00 00 20 00 00 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 00 20 20 20 20 0C 00 92 00 90 10 00 00 92 10 00 92 10 00 00 00 00 10 10 10 10 10 10 10 00 10 10 10 10 10 10 10 3F

Status: 80 82 A4 01 01 D4 F4 48 16 86 16 94 08 13 09 BB 0A 53 09 EF 08 59 09 68 09 CB 09 C5 00 A9 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 32 32 00 00 00 01 00 00 00 07 D9 07 08 00 01 FF 00 07 E1 0A 7B 07 E1 0A 7B 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 01 F4 1F 00 72 67 5B 97 2D 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 06 00 00 04 2D 00 00 00 C7 00 00 00 56 00 01 27 10 00 FF F1 00 00 32 00 F5 10 00 96 00 03 58 00 00 00 00 00 FF 00 00 00 00 00 00 00 00 00 00 02 6B 00 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 64

Not sure if this helps. It's the output from the Python tool using the above. (-30.0 is apparently the 'right' value upon checking). The labels are displayed in the right order :

from ithowifi.

Thanks for the info! I cannot explain why the first values are not parsed correctly but it seems it must be a bug somewhere. I'll draft some tests and dig into it somewhere this weekend probably.

from ithowifi.

Thanks for the effort so far and happy to help with testing.

from ithowifi.

This explains the status mapping issue, there are less than 37 versions mapped (I see only 28) This means that version 34 will be out of bound.

from ithowifi.

That's because there are fewer than 37 versions in the Itho database:

sqlite> select count(*) from versiebeheer;
27
sqlite> select count(distinct(datalabel)) from versiebeheer;
20

So if you are at version 34, you still need the array to have 35 (nullptr + 34) elements?

from ithowifi.

Ah, that explains! The array index = itho

does it make sense to get a new bin file with the amended array or do you want to do debugging first?

from ithowifi.

It probably does. In the current bin array position 34 does not exist but the code will happily return a memory address, which apparently (at least partly points) to readable strings but probably also points to junk. It is due to the resilience of the ArduinoJSON lib that this doesn't crash the program but it could definitely be the cause of the 0x92 glitches as well.

from ithowifi.

Digging through my own code, now I'm pretty sure it could be the source of the issue. Here the status label gets added to the vector:

What happens if junk gets fed? Probably exactly what we see...
I thought I'd built in protection for versions > supported (because itho always can start selling a newer version of their device) but clearly not.

from ithowifi.

Thanks for digging into this. And good to keep in mind when adding AutoTemp and WPU settings support. 😉

from ithowifi.

NRG_itho_wifi.ino.esp32.bin.zip
Ok, home again, quick copy paste of the array and a blind compile. Maybe you could test this and see if there are differences

from ithowifi.

Looks much better and values / descriptions seem to match upon first glance, will do a better comparison later on.

One observation: outdoor temp is apparently -30 but shown here as 625.36
Well both are logically wrong, the -30 is also what the Python tool shows so that's I expect here as well. Its data type is 0x92

from ithowifi.

Great! Thanks for testing!

F448 is actually an error code:

But nonetheless, it is handled als unsigned float incorrectly

from ithowifi.

Thanks, I was trying to load the data via MQTT in Home Assistant but it seems there's another fix needed?

This is not relevant anymore?

from ithowifi.

Everything else looks good OK now. Havent seen anything that looks completely off.

Some suggestions for next versions:

1. Add unit type (I can read it from Itho dbase and add it to the label) as otherwise it's difficult to interpret the values

Yes that would be great, the reason I did not include this (yet) is that it creates another layer of values and complexity. We then would have to register for every value the unit (or error code). In an DB this is easy, but the structure I chose (because of missing DB solution for arduino) is somewhat limited on this extend. Trade off between functionality and memory usage. But probably a lot more is possible but I lack the experience to know and use a different approach to be honest.

2. Selection of fields for MQTT?
   I guess out of all status values available, not everything is interesting for a HA system. MQTT supports the large message size all together and filtering can be done on receiving end, but sending a select number of fields feels cleaner.

Yes that is sure possible and I thought about this as well. This would put the burden on a relatively small and limited system, whereas the receiving system could quite easily parse the received info. For now I (hopefully) made the buffer large enough to accommodate all the values and there is still headroom to extend on the ESP32 platform if needed.

from ithowifi.

Everything else looks good OK now. Havent seen anything that looks completely off.
Some suggestions for next versions:

1. Add unit type (I can read it from Itho dbase and add it to the label) as otherwise it's difficult to interpret the values

Yes that would be great, the reason I did not include this (yet) is that it creates another layer of values and complexity.

Clear. So shall I just send a patch which adds the unit types to the labels? E.g. description (unit type).

I looked at the code to understand the parameter / setting processing. But while in the Itho database I see the min and max values, it looks like you read it from the device output itself?
not much of a c++ coder myself, just seeing what needs to be provided to get the settings to show up.

from ithowifi.

Clear. So shall I just send a patch which adds the unit types to the labels? E.g. description (unit type).

Ah, I misunderstood it. Adding it to the label itself is off-course easy and can be done without adding complexity.

from ithowifi.

My original idea was to have unit type separated from the description but after reading your comments on complexity, updating the description seems the easier way to go.

from ithowifi.

I've created #51 PR for the updated labels.

from ithowifi.

Hi, after following this issue closely I just have my WPU connected and I noticed the following:
Outdoor temp and Boiler temp below are showing 0 in status, while the Query status results returns actually plausible values.
80 82 A4 01 01 AA 04 4C 12 65 15 21 0A 20 0A 41 0B 8A 0A 7D 09 E9 0A 81 0B 1B 0A 00 00 76 00.....'
Outdoor temp: 11
Boiler temp below: 47.09

from ithowifi.

I might have found something.
My device returns device type 26, which is version 38 in decimal.
If I understand right that version isn't supported yet.

from ithowifi.

The versions are taken from the official Itho database hosted on Azure. So it should be up to date. It currently lists 37 as max.

Do you have a WPu 5g as well?

from ithowifi.

No a 4th generation. WPU-55I

from ithowifi.

That's interesting, I used the steps here: https://github.com/pommi/python-itho-wpu/tree/master and it doesn't mention that the HeatPump database is tied to 5th generation devices only.

Do you see correct labels / values for other fields?

I see this:

Itho device type: Heatpump
Itho fw version: 34

But you see this?
Itho device type: 26
Itho fw version: ???

But I think 26 is already in decimals so I guess the hex is 0x1A and it should be added here:

So perhaps the existing HeatPump entry is for 5th gen (5G) and there's a different identifier for 4G units, being the 0x1A.

from ithowifi.

My device returns device type 26, which is version 38 in decimal.

Where do you see this number? Could you post the output of the "Query Devicetype" command on the debug page?

from ithowifi.

I'm sorry, I should have posted the raw query result right away.
Query DeviceType returns
80 82 90 E0 01 07 00 01 00 0D 26 14 00 3E

from ithowifi.

I'm sorry, I should have posted the raw query result right away. Query DeviceType returns 80 82 90 E0 01 07 00 01 00 0D 26 14 00 3E

Thanks! So that is 0D for device type, which seems to be correctly the Heatpump. And 14 for the version number which translates to 20 in decimal. This version is also present in the code from jasper. Cannot really explain why it should not work.

from ithowifi.

NRG_itho_wifi.ino.esp32.bin.zip

@jasperslits (and @JoostBaltissen), I've compiled the PR you supplied and also included some code to better protect (and give error messages) when a version is not supported or out of band somehow.

from ithowifi.

Nice, this the new output, still some 0's on the begin and weird values at the end. See table below.
I don't see any odd messages in the log right now.

from ithowifi.

These are correct (manually added)

To check the others I need the status format output and the full status output from the debug page

from ithowifi.

Status format:
Result: 80 82 A4 00 01 6F 92 92 92 92 92 92 92 92 92 92 92 92 92 92 0C 0C 0C 0C 10 10 0C 00 00 00 10 10 0C 0C 0C 0C 0C 10 92 92 00 00 00 00 92 92 92 92 00 00 10 0C 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 10 12 00 00 20 00 00 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 0C 00 00 00 A2 A5 92 92 90 10 00 00 00 00 10 ED
Status:
Result: 80 82 A4 01 01 AA 02 58 0F 6B 13 A7 07 EC 08 24 09 58 08 06 08 6C 08 4F 08 F7 08 F7 00 76 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 02 D5 02 D5 00 00 00 01 00 00 00 08 65 08 34 00 01 FF 00 07 88 08 D2 07 88 08 D2 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 01 F4 1D 00 61 92 D9 C1 2D 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00 01 01 00 00 00 2C 00 6A DC B1 1B 87 00 00 00 3C 04 4C 01 17 05 35 00 00 B6

Log:
5785 N: System boot, last reset reason: POWERON_RESET
5802 N: HW rev: NON-CVE 1, FW ver.: 2.3-beta4
5937 N: wifi config saved
5966 N: Setup: Wifi config load failed
7733 N: wifi AP mode started
7754 N: Setup: AP mode active
7774 N: Setup: Virtual remote ID: 60,175,52
7801 N: Webserver: started
7822 N: mDNS: started
7842 N: Hostname: nrg-itho-af34
7863 N: Setup: done
2157 N: System boot, last reset reason: POWERON_RESET
2175 N: HW rev: NON-CVE 1, FW ver.: 2.3-beta4
2214 N: Setup: Wifi config load failed
3891 N: wifi AP mode started
3911 N: Setup: AP mode active
3929 N: Setup: Virtual remote ID: 60,175,52
3956 N: Webserver: started
3978 N: mDNS: started
4000 N: Hostname: nrg-itho-af34
4020 N: Setup: done
2158 N: System boot, last reset reason: POWERON_RESET
2176 N: HW rev: NON-CVE 1, FW ver.: 2.3-beta4
2214 N: Setup: Wifi config load failed
3892 N: wifi AP mode started
3914 N: Setup: AP mode active
3932 N: Setup: Virtual remote ID: 60,175,52
3958 N: Webserver: started
3980 N: mDNS: started
4001 N: Hostname: nrg-itho-af34
4021 N: Setup: done
222431 N: wifi config saved
238168 N: wifi config saved
259728 N: Reboot requested
2159 N: System boot, last reset reason: SDIO_RESET
2177 N: HW rev: NON-CVE 1, FW ver.: 2.3-beta4
6447 N: WiFi: connection successful
6466 N: WiFi info:
6485 N: Mode:STA
6503 N: Status:3
6522 N: IP:192.168.2.32
6541 N: Setup: Virtual remote ID: 60,175,52
6566 N: Webserver: started
6586 N: mDNS: started
6604 N: Hostname: itho-warmtepomp
6624 N: Setup: done
2021-11-13 21:06:01 N: Firmware update: NRG_itho_wifi.ino.esp32.bin
2021-11-13 21:06:17 N: Reboot requested
2021-11-13 21:06:19 N: System boot, last reset reason: SDIO_RESET
2021-11-13 21:06:19 N: HW rev: NON-CVE 1, FW ver.: 2.3-beta4-wputest
2021-11-13 21:06:23 N: WiFi: connection successful
2021-11-13 21:06:23 N: WiFi info:
2021-11-13 21:06:23 N: Mode:STA
2021-11-13 21:06:23 N: Status:3
2021-11-13 21:06:23 N: IP:192.168.2.32
2021-11-13 21:06:23 N: Setup: Virtual remote ID: 60,175,52
2021-11-13 21:06:23 N: Webserver: started
2021-11-13 21:06:23 N: mDNS: started
2021-11-13 21:06:23 N: Hostname: itho-warmtepomp
2021-11-13 21:06:23 N: Setup: done
2163 N: System boot, last reset reason: POWERON_RESET
2181 N: HW rev: NON-CVE 1, FW ver.: 2.3-beta4-wputest
6556 N: WiFi: connection successful
6574 N: WiFi info:
6592 N: Mode:STA
6610 N: Status:3
6628 N: IP:192.168.2.32
2021-11-13 21:12:09 N: Setup: Virtual remote ID: 60,175,52
2021-11-13 21:12:09 N: MQTT: connected, System config: 1
2021-11-13 21:12:09 N: Webserver: started
2021-11-13 21:12:09 N: mDNS: started
2021-11-13 21:12:09 N: Hostname: itho-warmtepomp
2021-11-13 21:12:09 N: Setup: done
2021-11-13 21:12:17 N: HA DISCOVERY: Start publishing MQTT Home Assistant Discovery...
2021-11-14 03:12:02 N: Mem free: 103744, Mem low: 75944, Mem block: 59320
2021-11-14 03:07:01 N: System boot, last reset reason: OWDT_RESET
2021-11-14 03:07:01 N: HW rev: NON-CVE 1, FW ver.: 2.3-beta4-wputest
2021-11-14 03:07:05 N: WiFi: connection successful
2021-11-14 03:07:05 N: WiFi info:
2021-11-14 03:07:05 N: Mode:STA
2021-11-14 03:07:05 N: Status:3
2021-11-14 03:07:05 N: IP:192.168.2.32
2021-11-14 03:07:05 N: Setup: Virtual remote ID: 60,175,52
2021-11-14 03:22:39 N: MQTT: connected, System config: 1
2021-11-14 03:22:39 N: Webserver: started
2021-11-14 03:22:39 N: mDNS: started
2021-11-14 03:22:39 N: Hostname: itho-warmtepomp
2021-11-14 03:22:39 N: Setup: done
2021-11-14 03:22:48 N: HA DISCOVERY: Start publishing MQTT Home Assistant Discovery...
2021-11-14 09:22:33 N: Mem free: 140736, Mem low: 97944, Mem block: 60544
43200049 N: Mem free: 133944, Mem low: 97944, Mem block: 60544
2021-11-14 20:13:19 N: HA DISCOVERY: Start publishing MQTT Home Assistant Discovery...
2021-11-14 20:33:25 N: HA DISCOVERY: Start publishing MQTT Home Assistant Discovery...
2021-11-14 21:22:33 N: Mem free: 140344, Mem low: 97944, Mem block: 60544
2021-11-15 03:22:33 N: Mem free: 131916, Mem low: 97944, Mem block: 60544
2021-11-15 09:22:33 N: Mem free: 140044, Mem low: 97944, Mem block: 60544
2021-11-15 15:22:34 N: Mem free: 138032, Mem low: 97944, Mem block: 60544
2021-11-15 15:46:19 N: HA DISCOVERY: Start publishing MQTT Home Assistant Discovery...
2021-11-15 21:22:34 N: Mem free: 140280, Mem low: 97936, Mem block: 60544
2021-11-15 21:58:56 N: Firmware update: NRG_itho_wifi.ino.esp32.bin
2021-11-15 21:59:11 N: Reboot requested
2021-11-15 22:00:36 N: System boot, last reset reason: SDIO_RESET
2021-11-15 22:00:36 N: HW rev: NON-CVE 1, FW ver.: 2.3-beta4-wputest
2021-11-15 22:00:41 N: WiFi: connection successful
2021-11-15 22:00:41 N: WiFi info:
2021-11-15 22:00:41 N: Mode:STA
2021-11-15 22:00:41 N: Status:3
2021-11-15 22:00:41 N: IP:192.168.2.32
2021-11-15 22:00:41 N: Setup: Virtual remote ID: 60,175,52
2021-11-15 22:00:41 N: MQTT: connected, System config: 1
2021-11-15 22:00:41 N: Webserver: started
2021-11-15 22:00:41 N: mDNS: started
2021-11-15 22:00:41 N: Hostname: itho-warmtepomp
2021-11-15 22:00:41 N: Setup: done
2021-11-15 21:59:28 N: HA DISCOVERY: Start publishing MQTT Home Assistant Discovery...

from ithowifi.

if I compare your version 20 mapping with de database jaspers' mentioning some labels are off and the length is not the same. So maybe there is an issue with the script of Jasper? @jasperslits could you maybe share the script?

from ithowifi.

I am a lazy coder so it's an ugly PHP script.

But Itho has per version a table, so for version 20 there are 111 elements where as version 34 (mine) has 123 labels. I assumed that the 111 elements of version 20 overlap with the first 111 of version 34.

But when I use the Python script of Pommi with the provided status format and status, it yields two errors but I guess these data types are handled in the C++ code already:
Unknown data type for label Pbron: 0xA2
Unknown data type for label Ibron: 0xA5