Giter VIP home page Giter VIP logo

Comments (8)

earthlng avatar earthlng commented on May 18, 2024

There's only one item for sandboxing and it's only to inform users. I'd prefer if you create a New Issue with FYI label and list the Prefs and URLs there, and we remove that item from the section and make the section only for e10s.
Idk if it really needs to be such a low number like 0050, because once e10s is ready and default enabled everywhere + only WebExtensions are allowed, the only thing that someone maybe needs/wants to change is the process count number. I'd even say it could go under Personal, maybe as 3100 or so.
If you want to keep the 0050 then it shouldn't have 006x.
0061 - idk if this is ready to use just yet. Maybe better to keep this in our sticky to keep an eye on.
0061+2 both rely on e10s so I don't see why they have a new sub-number ie. 006x instead of 005x.
0061 - copypasta: pref instead of user_pref

The rest is great! very nice section description and all the item titles and links and stuff is great too.

from user.js.

earthlng avatar earthlng commented on May 18, 2024

Just like we have other items to dispel bad advice

Yeah, fair enough, but we now have a github page for the user.js and IMO that item doesn't need to be in the user.js, but whatever. just my 2 cents

I see no point in removing one to keep an eye on but keeping the other

One is a fairly "simple" local file isolation that's almost never used and doesn't really matter much if something is not quite ready yet or breaks, while the other is probably a pretty complex addon isolation with tons of potential problems. I'm not even using a single WebExtension addon yet.

stuck shim as last item since it will be the first and maybe only one to be deprecated

๐Ÿ‘

I don't think this is personal at all - this is about security

It's definitely about security but as I said, thinking ahead and once FF57 hits we end up with a section at the top of the file that nobody really needs to change anymore. Thats my only concern.

from user.js.

earthlng avatar earthlng commented on May 18, 2024

1100 seems fine. But I don't like making containers 1150 because they're independent from e10s.
Since containers don't seem to work with PB (for now?), containers could be more towards the top of the file, because if someone enables PB-only mode the container prefs are irrelevant. So containers could be 0050.

from user.js.

earthlng avatar earthlng commented on May 18, 2024

53 is now delayed until the 26th AFAIK

not according to the RapidRelease page. Maybe the 26th is just for a new Dev Edition (now based on Beta). Idk where that date is coming from tbh

3000 to 5000

I guess Personal will always be the last section so if we renumber we should probably renumber it to 8000

from user.js.

earthlng avatar earthlng commented on May 18, 2024

I think we can go with your draft but I'd add a note about 1103 maybe not being quite ready yet, and for 1110 maybe add a newline after DO NOT MEDDLE WITH THESE

from user.js.

earthlng avatar earthlng commented on May 18, 2024

I really don't like adding prefs that we recommend to not meddle with. What if we create a new section for such prefs (if you insist on keeping them in the file itself)? I'd be okay with that. Somewhere towards the end preferably. A sticky would also be an option.

from user.js.

earthlng avatar earthlng commented on May 18, 2024

Are the syntax errors in 1110 on purpose?

from user.js.

earthlng avatar earthlng commented on May 18, 2024

is that what u meant?

nope, that's not a syntax error but these are

from user.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.