Giter VIP home page Giter VIP logo

Comments (11)

Pratyush avatar Pratyush commented on August 16, 2024

Are the tests in the Groth16 repo passing?

from ivls.

weikengchen avatar weikengchen commented on August 16, 2024

Yes, tests in PCD and Groth16 are both passing.

But IVLS even before the commit before your commit is failing.

from ivls.

weikengchen avatar weikengchen commented on August 16, 2024

So, I need to dig deeper. One of my guesses is whether the problem only pops up when the FFT instance is sufficiently large or very close to something.

from ivls.

Pratyush avatar Pratyush commented on August 16, 2024

Do you know what the size of the constraint system is here?

from ivls.

weikengchen avatar weikengchen commented on August 16, 2024

Let me quickly find a number...

from ivls.

weikengchen avatar weikengchen commented on August 16, 2024

It appears that the number is about 218246 for MainCircuit and 33322 for HelpCircuit. These seem to be some common sizes and are likely not the reasons for failing.

Groth16 verifier constraint is where it fails. In other words, when I removed the Groth16 verifier from both MainCircuit and HelpCircuit, PCD no longer complains that the constraint system is not satisfactory, but the final proof is not verified outside either.

The next step of my testing is likely to see if both raw proofs can be verified outside SNARK---if it cannot, then likely there is an issue with Groth16. If it can, then there is likely a problem with the Groth16 verifier gadget.

from ivls.

Pratyush avatar Pratyush commented on August 16, 2024

@weikengchen maybe this is the issue: arkworks-rs/algebra#243 ?

from ivls.

weikengchen avatar weikengchen commented on August 16, 2024

More info:

  • Groth16 prover/verifier passes for 300k constraints.
  • Groth16 verifier circuit passes for 300k constraints.

It seems that arkworks-rs/algebra#243 may be very related. So I will likely wait on that one...

from ivls.

Pratyush avatar Pratyush commented on August 16, 2024

@weikengchen Do these tests pass now?

from ivls.

Pratyush avatar Pratyush commented on August 16, 2024

The tests do indeed pass, so that should resolve this issue!

from ivls.

weikengchen avatar weikengchen commented on August 16, 2024

It passes!

from ivls.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.