Comments (4)
Send a pull request with your suggestions :) open source! What specifically would be better in this code using the class feature?
I'd personally not suggest to ever use classes, but that's my preference.
from pokemon-go-node-api.
I'll throw in my 2 cents: typescript and ES6 classes are great, but considering the nature of the project and the fact that at any moment the endpoints, protocols, etc. could change, I think that whatever design patterns the contributors are comfortable with are the best ones to go with. It seems like at this point the big hurdle is reading data through the buffer correctly and reliably.
from pokemon-go-node-api.
Usually I prefer to use pure node.js callback with an OOP like structure
from pokemon-go-node-api.
yield, generators, async, await, promise, es6 classes, node-fetch is my preference
And also the use of async-classes
from pokemon-go-node-api.
Related Issues (20)
- Cannot get coordinates of nearby/map pokemon
- [Question] How to get pokemon attacks ? HOT 3
- Cannot find module 'request' HOT 1
- Inventory parameter of GetInventory is null HOT 1
- EvolvePokemon : error regarding cp_multiplier HOT 2
- Refresh Token when user log in with Google HOT 2
- Launch Berry? HOT 2
- self.GetApiEndpoint doesn't work HOT 3
- Capture pokemon
- Unable to host project
- CatchPokemon return null!! HOT 1
- Error when building with webpack
- Get Pokemon Coords
- Wrong values in MapPokemon.ExpirationTimeMs
- api 0.39
- pogo.GetProfile throws exception after successful login HOT 2
- Cannot authenitcate with Google, even with App Password HOT 2
- Getting null/rpc
- maybe beginner's mistake HOT 1
- Translate Documentation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pokemon-go-node-api.