Giter VIP home page Giter VIP logo

Comments (10)

arnthor3 avatar arnthor3 commented on May 5, 2024 1

Sure, if you are in a hurry you could do a pull request otherwise I will be able to tackle this later this week.

from react-bootstrap-toggle.

arnthor3 avatar arnthor3 commented on May 5, 2024 1

I will build and publish like this tonight, thanks for the help 👍

from react-bootstrap-toggle.

arnthor3 avatar arnthor3 commented on May 5, 2024 1

published, thanks for the help.

from react-bootstrap-toggle.

danosaure avatar danosaure commented on May 5, 2024 1

Hey, I just looked at your peerDependency update, and notice you didn't push the version bump commit. Just in case you forgot to commit and push.

from react-bootstrap-toggle.

danosaure avatar danosaure commented on May 5, 2024

Great, I think my colleague would make a PR to get this rolling.

from react-bootstrap-toggle.

arnthor3 avatar arnthor3 commented on May 5, 2024

Awesome thanks.
Don´t we need to update the peer dependencies to include react v.15* ?

from react-bootstrap-toggle.

danosaure avatar danosaure commented on May 5, 2024

Yeah, sorry, I was not familiar with that part, for which versions your plugin would be compatible, but maybe if you just set them as >=15.0.0 when you bump the version?

  "peerDependencies": {
    "react": ">=15.0.0",
    "react-dom": ">=15.0.0"
  }

from react-bootstrap-toggle.

arnthor3 avatar arnthor3 commented on May 5, 2024

How about something like this from React-MD?

  "peerDependencies": {
    "react": ">= 15.3.0 || 16.0.0",
    "react-dom": ">= 15.3.0 || 16.0.0"
  },

And maybe expand it like this

  "peerDependencies": {
    "react": ">= 15.0.0 || >= 16.0.0",
    "react-dom": ">= 15.0.0 || >= 16.0.0"
  },

Maybe something like this would work?

from react-bootstrap-toggle.

danosaure avatar danosaure commented on May 5, 2024

Sounds good if that works. I admit that I have never do alternatives peerDependencies. Also, I usually don't have a space after the >=:

  "peerDependencies": {
    "react": ">=15.0.0 || >=16.0.0",
    "react-dom": ">=15.0.0 || >=16.0.0"
  },

I have tried with above settings and it complains when I don't install any react, or react@0. So it sounds good like this.

from react-bootstrap-toggle.

danosaure avatar danosaure commented on May 5, 2024

play with npm outdated if you want too... Some versions are very old. But that can wait as it won't impact our work.

from react-bootstrap-toggle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.