Giter VIP home page Giter VIP logo

Comments (19)

arrowtype avatar arrowtype commented on June 2, 2024

Hey Behdad, this is a super cool report! At least in the PDF visuals, the suggested fixes all appear to be worse than the midway interpolations. But, Recursive is definitely a complex designspace with some unusual interpolations, so it's understandable that an automated tool might misinterpret a few of parts of it.

I'll close this issue, but please feel free to let me know if there's anything you think I might be missing.

Thanks!

from recursive.

behdad avatar behdad commented on June 2, 2024

Yeah the tool cannot always propose good solution. But the first glyph seems to have kinks in that are probably unintended.

from recursive.

arrowtype avatar arrowtype commented on June 2, 2024

Oh, upon second look, you are correct! Thanks for pointing that out.

from recursive.

behdad avatar behdad commented on June 2, 2024

Hi again,

I'm implementing a kink-detector. It's still far from complete. But I thought I get your feedback on it.

out.pdf

from recursive.

behdad avatar behdad commented on June 2, 2024

I think my question is, is this useful? Or those differences are small enough to let go? Basically, I'm trying to calibrate the tool.

from recursive.

arrowtype avatar arrowtype commented on June 2, 2024

Ooh, yes, this is amazing! Definitely a useful thing to find issues that were hard to locate, before. I especially want to try this out on Shantell Sans, next.

from recursive.

arrowtype avatar arrowtype commented on June 2, 2024

Some of the differences here are small enough to let go of, IMO. In particular, the /percent glyph is deliberately weird, and I don't see any super noticeable issues in the /one. But, seeing the issues in the the /Euro and /uni02C8 is very informative, and those are things I'd like to improve.

from recursive.

behdad avatar behdad commented on June 2, 2024

Here's a much more aggressive version. I'm still tuning. :)

out.pdf

from recursive.

behdad avatar behdad commented on June 2, 2024

Retweaked. Shantell Sans. Catches one that doesn't matter.

out.pdf

from recursive.

arrowtype avatar arrowtype commented on June 2, 2024

These are great! The more aggressive version is nice, imo. Does the command line version have an arg for threshold?

from recursive.

behdad avatar behdad commented on June 2, 2024

These are great! The more aggressive version is nice, imo.

Interesting. I thought it would be too busy. I'm still tweaking.

Does the command line version have an arg for threshold?

It will have, when I'm done with it.

from recursive.

behdad avatar behdad commented on June 2, 2024

Does the command line version have an arg for threshold?

It will have, when I'm done with it.

For now I'm reusing the existing --tolerance. But I'll probably add a separate knob for just the kink checker as well.

from recursive.

behdad avatar behdad commented on June 2, 2024

Here's what I'm happy with as default tolerance.

out.pdf

from recursive.

behdad avatar behdad commented on June 2, 2024

I settled on this for default, for now. There's --kinkiness parameter you can tweak. Might tweak the defaults again. Your thoughts?

out.pdf

from recursive.

behdad avatar behdad commented on June 2, 2024

That was way too much subtle details for the catalog. I'm trying this setting now.

out.pdf

You can still get the aggressive result if you want by setting --kinkiness to 1 or above. It defaults to .5 now.

from recursive.

behdad avatar behdad commented on June 2, 2024

How about this as default?

out.pdf

from recursive.

behdad avatar behdad commented on June 2, 2024

I made the default conservative, as across the catalog it was overwhelming the reports...

from recursive.

behdad avatar behdad commented on June 2, 2024

Here's what the current output looks like.
out.pdf

from recursive.

arrowtype avatar arrowtype commented on June 2, 2024

Hey, this output is super helpful! Thanks again for the excellent testing tool. I’ll try to fix these kinks in the coming weeks, and make a new release early in the new year.

from recursive.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.