Hello! Sorry for my English. I set the aspect ratio of 1: 1 (squ

Aspect ratio 1:1 (square), it turns out not square about android-image-cropper HOT 7 CLOSED

arthurhub commented on July 19, 2024

Aspect ratio 1:1 (square), it turns out not square

from android-image-cropper.

Comments (7)

ArthurHub commented on July 19, 2024

classic off-by-1 bug :)
fixed in v1.2.5

from android-image-cropper.

tweaker commented on July 19, 2024

Thank you very much for your efficiency!
But some coordinates still manifests the bug that the height is greater than the width:
As I understand it, in some cases, to the height of 1px flops

Actual crop rect: Rect(419, 626 - 2847, 3053)
Actual crop rect.left: 419
Actual crop rect.top: 626
Actual crop rect.right: 2847
Actual crop rect.bottom: 3053
Actual crop rect.width: 2428
Actual crop rect.height: 2427

Actual crop rect: Rect(0, 321 - 2847, 3167)
Actual crop rect.left: 0
Actual crop rect.top: 321
Actual crop rect.right: 2847
Actual crop rect.bottom: 3167
Actual crop rect.width: 2847
Actual crop rect.height: 2846

3053 - 626 = 2427 - height
2847 - 419 = 2428 - width

from android-image-cropper.

ArthurHub commented on July 19, 2024

are you sure you updated to 1.2.5?
I'm unable to reproduce it now.

from android-image-cropper.

tweaker commented on July 19, 2024

Yes I updated to version 1.2.5.
Also cleared the project, deleted from the phone app and reinstalled everything.
Previously, it was the inaccuracy of 1-2 pixels. Now only 1 pixel.
The bug manifests itself only in portrait mode.

My template:

<com.theartofdev.edmodo.cropper.CropImageView xmlns:custom="http://schemas.android.com/apk/res-auto"
            android:id="@+id/cropImageView"
            android:layout_width="0dp"
            android:layout_height="match_parent"
            android:layout_weight="1"
            android:background="@drawable/rect_cropper"
            custom:cropInitialCropWindowPaddingRatio="0"
            custom:cropMinCropResultHeightPX="700"
            custom:cropMinCropResultWidthPX="700"
            custom:cropScaleType="fitCenter" />

from android-image-cropper.

tweaker commented on July 19, 2024

And not just in the horizontal position of a difference there is in 2 pixel:

Actual crop rect: Rect(0, 0 - 2850, 2848)
Actual crop rect.left: 0
Actual crop rect.top: 0
Actual crop rect.right: 2850
Actual crop rect.bottom: 2848
Actual crop rect.width: 2850
Actual crop rect.height: 2848

from android-image-cropper.

ArthurHub commented on July 19, 2024

sorry, totally missed that it can be off by 2 =/
please try 1.2.6, let me know if it works

from android-image-cropper.

tweaker commented on July 19, 2024

Everything works fine! Thank you very much for your help!