Internet Explorer 8 - SCRIPT5007: Unable to get value of the property 'i': object is null or undefined about fotorama HOT 7 CLOSED

Have you a demo?

SCRIPT5007: Unable to get value of the property 'i': object is null or undefined
fotorama.js?mqw9c0, line 1372 character 7

Seems to checkForVideo() function, under dataFrame.i) doesn't seem to like IE8:

$.each(data, function (i, dataFrame) {
if (!dataFrame.i) {
dataFrame.i = dataFrameCount++;
var video = findVideoId(dataFrame.video, true);
if (video) {
var thumbs = {};
dataFrame.video = video;
if (!dataFrame.img && !dataFrame.thumb) {
thumbs = getVideoThumbs(dataFrame, data, that);
} else {
dataFrame.thumbsReady = true;
}
updateData(data, {img: thumbs.img, thumb: thumbs.thumb}, dataFrame.i, that);
}
}
});
}

—
Reply to this email directly or view it on GitHub.

from fotorama.

Changing my code the following: #42

Seems to have fixed the issue, using the question #17 (comment) was giving me dramas.

Thanks!

from fotorama.

Hi another thing I've noticed with IE8 - The main image doesn't fit properly.

If you open the examples at http://fotorama.io/customize/fullscreen/ and try them in IE8 (If you have IE10 you can do IE8 mode, or use one of the free virtual machines Microsoft now provides) you will see it doesn't fit properly.

from fotorama.

Can you give me a screenshot?

from fotorama.

Sure!

IE8: http://i.imgur.com/RzGwGTS.jpg
IE9 (Works perfectly): http://i.imgur.com/lW3ZKGP.jpg

IE8 doesn't resize the image properly, so the nav (thumbnails or dots) doesn't show as it's pushed down.

I'm using the examples at http://fotorama.io/customize/fullscreen/ .

from fotorama.

Confirmed.

from fotorama.

Fotorama now works perfectly in IE7/IE8.

from fotorama.