Comments (2)
Apparently there's also a compile error when building against the latest containers
:
Data/ListTrie/Base/Map.hs:346:17: error:
• Data.Map.insertWith' is gone. Use Data.Map.Strict.insertWith.
• In the expression: M.insertWith'
In an equation for ‘insertWith’: insertWith = M.insertWith'
In the instance declaration for ‘Map M.Map k’
from list-tries.
Yes, I'm afraid it's not as simple as bumping upper bounds. containers
0.6 removes the old semi-strict insertWith'
-style APIs from Data.Map
which have been deprecated for a long time. In principle we could remove the one character and use plain insertWith
, but I'm unsure as to what kind of behavioural effect that has so I'm a bit uncomfortable with doing it just off the cuff.
My understanding is that these APIs were removed in favour of Data.Map.Strict
because they were misleading and not as strict as people expected, but that they did still behave differently than the fully lazy versions. Perhaps the correct thing to do for list-tries
would be to use Data.Map.Strict
internally, but that's another thing that would need a bit deeper evaluation.
Unfortunately my time is really limited these days and list-tries
has suffered for it. Since I'm unlikely to be able to take the time to do a proper analysis any time soon, I'm going to have to go with the "PRs welcome" response here. Note that fixing the compile error is easy — the key issue is that I'd like to have some understanding of the implications.
from list-tries.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from list-tries.