Giter VIP home page Giter VIP logo

Comments (7)

phogel avatar phogel commented on September 4, 2024

Hey thanks for asking. Working on it right now. Will let you know when the fix is up👍

from oil.

kleins avatar kleins commented on September 4, 2024

Thanks for the reply. What will be your solution? I've read something about Polyfill which should help to solve this Problem. Polyfill was also available in version 1.1.0. But with Polyfill we had some problems on some sites which also implemented Polyfill.

Thanks

from oil.

phogel avatar phogel commented on September 4, 2024

We removed the babel-polyfill because it interfered with some of our sites, too.
Promise is polyfilled but the new error you're seeing is from inside the ConsentString library – Object.assign is used but not polyfilled.
Now we're going to load the polyfills dependent on whether the browser provides them natively or not. You can view my current implementation state here: https://github.com/as-ideas/oil/blob/oil-190-browserstacks/src/polyfill.js

from oil.

phogel avatar phogel commented on September 4, 2024

The fix has been merged with #150

from oil.

kleins avatar kleins commented on September 4, 2024

thank you for your reply.
I've checkt the merge and sadly it didn't work as expected. In IE 9 I get a similar error (see Screenshot), but consent layer is displayed as expected.

In IE 10 __cmp callback function would not called:

__cmp('getVendorConsents', null, function (result) {
    // The callback is never called
    my_lib.consent_given = true;
});

So consent wouldn't given.

This behaviour also happen in IE 9.

IE 11, seems to work as expected. Consent the callback is called and consent is given
dashboard 2018-06-25 14-51-05

from oil.

phogel avatar phogel commented on September 4, 2024

The fill method will be polyfilled in the next release. See this PR #154
Will write a seperate test for getVendorConsents on IE10

from oil.

Waschnick avatar Waschnick commented on September 4, 2024

With Version 1.2.1 there should be no issues.

from oil.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.