Giter VIP home page Giter VIP logo

Comments (8)

aaron02 avatar aaron02 commented on June 15, 2024 2

image
doing this in NPCHandler fixes the issue, but @Zyres should look at it if its right ^^

from ascemu.

Zyres avatar Zyres commented on June 15, 2024 2

@aaron02 looks good <3

from ascemu.

schnek avatar schnek commented on June 15, 2024 1

yes for me in all versions there is such a problem ๐Ÿคจ

from ascemu.

schnek avatar schnek commented on June 15, 2024 1

not, i tested with develop. when the crash shows the stopping place line: https://github.com/AscEmu/AscEmu/blob/develop/src/world/Spell/SpellInfo.hpp#L134

from ascemu.

Appled avatar Appled commented on June 15, 2024

Does it crash on all versions?

from ascemu.

Appled avatar Appled commented on June 15, 2024

Btw does it crash on master branch?

from ascemu.

schnek avatar schnek commented on June 15, 2024
    TrainerSpell const* trainerSpell = nullptr;
    std::vector<TrainerSpell>::const_iterator itr;
    std::vector<TrainerSpell> itr = sObjectMgr.getTrainserSpellSetById(trainet->spell_id);
    
    for (itr = itr.begin(); itr != itr.end(); itr++)
    {
        if ((itr->castSpell && itr->castSpell->getId() == srlPacket->spellId) ||
            (itr->learnSpell && itr->learnSpell->getId() == srlPacket->spellId))
        {
            trainerSpell = &(*itr);
            break;
        }
    }

yes this works as it should and fixes the problem

from ascemu.

schnek avatar schnek commented on June 15, 2024

fix 761ef69

from ascemu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.