Comments (8)
doing this in NPCHandler fixes the issue, but @Zyres should look at it if its right ^^
from ascemu.
@aaron02 looks good <3
from ascemu.
yes for me in all versions there is such a problem ๐คจ
from ascemu.
not, i tested with develop. when the crash shows the stopping place line: https://github.com/AscEmu/AscEmu/blob/develop/src/world/Spell/SpellInfo.hpp#L134
from ascemu.
Does it crash on all versions?
from ascemu.
Btw does it crash on master branch?
from ascemu.
TrainerSpell const* trainerSpell = nullptr;
std::vector<TrainerSpell>::const_iterator itr;
std::vector<TrainerSpell> itr = sObjectMgr.getTrainserSpellSetById(trainet->spell_id);
for (itr = itr.begin(); itr != itr.end(); itr++)
{
if ((itr->castSpell && itr->castSpell->getId() == srlPacket->spellId) ||
(itr->learnSpell && itr->learnSpell->getId() == srlPacket->spellId))
{
trainerSpell = &(*itr);
break;
}
}
yes this works as it should and fixes the problem
from ascemu.
fix 761ef69
from ascemu.
Related Issues (20)
- ๐พ [Bug Report] chat problem on all versions HOT 9
- ๐พ [Bug Report] CMake Warning HOT 1
- ๐พ [Bug Report] Crash when entering the game. HOT 3
- ๐พ [Bug Report] Crash OnStartup when Loading Groups HOT 1
- ๐พ [Bug Report] caught another crash ๐ (Crash, kill NPCs 10-15 minutes) HOT 2
- ๐พ [Bug Report] [CATA] - The Shadow Grave Quest HOT 1
- ๐พ [Bug Report] errors when building on Linux (Clang) HOT 3
- ๐พ [Bug Report] [MOP] Missing handler for SmsgShowBank
- ๐พ [Bug Report] [MOP] Missing handler for CMSG_SET_ACTION_BUTTON
- ๐พ [Bug Report] [MOP] Missing handler for CMSG_GOSSIP_HELLO
- ๐พ [Bug Report] [MOP] Missing handler for CMSG_BANKER_ACTIVATE
- ๐พ [Bug Report] [Cata+] removed trigger-npc
- ๐พ [Bug Report] TBC Client/Server Crash after teleport
- ๐พ [Bug Report] support for new version OpenSSL
- ๐พ [Bug Report] Battlemasters and Talents buged or still no fixed HOT 1
- โ [Support Request] Quest 6661 Deeprun Rat Roundup anomaly.
- ๐พ [Bug Report] Dual Talent HOT 1
- ๐พ [Bug Report] Summon Imp - server crash HOT 2
- ๐พ [Bug Report] afk player - server crash HOT 2
- โ [Support Request] Quest - Lazy peon
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ascemu.