Memory issue with autoplay + loop about asciinema-player HOT 6 CLOSED

Thanks for reporting. I'll investigate.

from asciinema-player.

@daetherius You can re-enable loop and it should be fine now.

from asciinema-player.

@sickill - sorry to bug you, just curious - how'd you go about diagnosing+debugging this issue? i'm a rookie cljs dev and wouldn't know where to start if one of my apps had an issue like this. is there a particular portion of the chrome developer tools that was useful for you here, or some sort of blog post where you learned about how to debug js memory issues, etc? thanks a ton!

from asciinema-player.

@sickill Thank you very much!

from asciinema-player.

@jrheard sure! So, I opened Chrome's "task manager", loaded asciicast page with loop on and observed the growing memory for this tab. Then I stopped playback and noticed that memory is no longer growing but the CPU usage is ~60% for this tab. So I went to dev tools, and created CPU usage profile (just went to Profiles and hit "Start" there). It showed me a list of functions that were observed to be running by profiler. I chose the one with the highest % next to it. It was from core.async so I kept expanding the call tree and at about 4th or 5th level, after getting through all core.async/clojure.core calls I got to a function from my namespace. The line number pointed me to a line where I start (go ...) block. Then I just analyzed this function and few others that call it and realized that I used core.async' sliding-buffer (I had a reason for that), which is non-blocking buffer, meaning that it's not enough to stop reading from this channel to stop (block) the producer (which in my case was still running even after the playback was stopped).

from asciinema-player.

Thanks a ton, that's super helpful information to have for when an issue like this inevitably bites me in my own projects :)

from asciinema-player.