Giter VIP home page Giter VIP logo

Comments (6)

jquast avatar jquast commented on July 16, 2024 2

May I please mention this article that details the varying display of Wide characters across Terminals in depth,

https://jeffquast.com/post/terminal_wcwidth_solution/

Perhaps the asciinema recorder could determine the Terminal's Unicode Version support level in the same way as the https://github.com/jquast/ucs-detect/ CLI tool that I recently published, and include the version in the metadata for the web player to honor, if the player could support selection by multiple versions of Unicode.

from asciinema-player.

ku1ik avatar ku1ik commented on July 16, 2024 2

The recently released 3.7.1 version of the player got several improvements around rendering accuracy, mostly fixing positioning and alignment of various character groups (ascii drawing, block elements, Powerline symbols, CJK, emoji). It now uses unicode-width library which helped quite a lot. It's not a 100% solution but it should look much better than before now.

The minesweeper demo looks perfectly aligned now:

image

The Asian characters demo is better now, although there's some glitching especially when the cursor moves over the double-width chars:

image

In summary: we're getting there 😅

from asciinema-player.

derhuerst avatar derhuerst commented on July 16, 2024 1

I'm having this problem with Emojis. Check cli-minesweeper to try it out in your Terminal.

BTW @sickill thanks for this amazing tool & web service!

from asciinema-player.

ku1ik avatar ku1ik commented on July 16, 2024

Thanks for bringing this up. I was aware of this since I created the player. This requires major changes to the internal virtual terminal implementation and so far hasn't been an issue for asciinema users thus it wasn't a high priority task for anyone.

from asciinema-player.

ku1ik avatar ku1ik commented on July 16, 2024

It may be worth looking at Unicode 9 widths (example impl here: https://github.com/joshuarubin/wcwidth9), which may be a better fit than classic wcwidth()-style calculation.

from asciinema-player.

ku1ik avatar ku1ik commented on July 16, 2024

@jquast thanks for linking to, and writing that blog post! It's going to be super useful when fixing this problem in asciinema player 🙇

from asciinema-player.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.