Giter VIP home page Giter VIP logo

Comments (9)

tintindas avatar tintindas commented on July 20, 2024 2

Oh! That makes so much more sense. I misunderstood the code. Sure, I'll go ahead and write the documentation if it does not require any env variables :)

from github-readme-activity-graph.

Ashutosh00710 avatar Ashutosh00710 commented on July 20, 2024 1

Specifically, the http://github-calendar.herokuapp.com/commits/last/${userId} route looks like it consumes some kind of github authorisation token if I am not mistaken.

No, @tintindas there is no authorization token is required to fetch the user's contributions. Because, according to me, currently there is no way to get a user's everyday contributions using GitHub API, that's why we are using this URL.

http://github-calendar.herokuapp.com/commits/last/${userId} is fetching the user's contributions through some kind of html parsing.

Source of the URL

from github-readme-activity-graph.

Ashutosh00710 avatar Ashutosh00710 commented on July 20, 2024 1

Hey @tintindas, I am reassigning this issue to you.

from github-readme-activity-graph.

tintindas avatar tintindas commented on July 20, 2024 1

@Ashutosh00710 great!!! 👍

from github-readme-activity-graph.

Kshitij978 avatar Kshitij978 commented on July 20, 2024

Thanks, @tintindas for the appreciation and for opening this issue. 😄

This addition will definitely improve the quality of the documentation. Do you want to add it yourself or you want us to do so?

from github-readme-activity-graph.

tintindas avatar tintindas commented on July 20, 2024

I took a look at the repo and I don't think I could write a set up guide without knowing the environment variables being consumed by the project, if any.

Specifically, the http://github-calendar.herokuapp.com/commits/last/${userId} route looks like it consumes some kind of github authorisation token if I am not mistaken.

Also, the mentioned route can be accessed by anyone even though its purpose is internal.

This is the response when I query with my own username. I do not believe it is exposing sensitive information at the moment.

image

from github-readme-activity-graph.

Ashutosh00710 avatar Ashutosh00710 commented on July 20, 2024

Great @tintindas, go ahead. 🙂

from github-readme-activity-graph.

Ashutosh00710 avatar Ashutosh00710 commented on July 20, 2024

Hey @tintindas, Sorry for the inconvenience. I unassigned you from the issue because I think I got the expected (user's contribution per day) response from GitHub API. If that's the case, it will include the environment variable.

I am keeping this issue open. Just hold for 1 or 2 days, until I am trying. I will let you know and reassign you the issue.

PS: What a lucky day as I was searching for the fix from the starting of the project but I couldn't find any. I dug a lot today and fortunately I think I got it. 😲✨

from github-readme-activity-graph.

Ashutosh00710 avatar Ashutosh00710 commented on July 20, 2024

Issue #26 closed with commit number 140. Integrated GitHub GraphQl API. Now one environment variable TOKEN is added.
We are updating How To Contribute section of CONTRIBUTING.md

from github-readme-activity-graph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.