Giter VIP home page Giter VIP logo

Comments (5)

ashutosh1919 avatar ashutosh1919 commented on August 15, 2024 1

@Sachin-chaurasiya , I think we should try correcting it now itself. The reason behind it (IMO) is that it will be difficult changing this once we add more functionality. It may also accumulate errors. Since, the project is in the initial stage, it will be good if we can rectify it now. Also, feel free to work in same PR. No need to create a new one.

from react-awesome-shapes.

Sachin-chaurasiya avatar Sachin-chaurasiya commented on August 15, 2024 1

@ashutosh1919, sure. will continue to work on the same PR.

from react-awesome-shapes.

ashutosh1919 avatar ashutosh1919 commented on August 15, 2024

@Sachin-chaurasiya , yes I have used it to adjust values corresponding to the breakpoint. Still, it is not the best solution. Sure, I am assigning this issue to you. You may want to approach solution like this (IMO): remove entire usage of media query. instead, find the value to use for this particular screen size. solution should be pure JS. Then, we can eleminate react-responsive.

from react-awesome-shapes.

Sachin-chaurasiya avatar Sachin-chaurasiya commented on August 15, 2024

@ashutosh1919, sure would love to work on it.
but for now, can we go with this approach? let me know what are your thoughts.

from react-awesome-shapes.

Sachin-chaurasiya avatar Sachin-chaurasiya commented on August 15, 2024

Not happening anymore so closing it.
Feel free to open it if the issue still persists.

from react-awesome-shapes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.