Comments (5)
@Sachin-chaurasiya , I think we should try correcting it now itself. The reason behind it (IMO) is that it will be difficult changing this once we add more functionality. It may also accumulate errors. Since, the project is in the initial stage, it will be good if we can rectify it now. Also, feel free to work in same PR. No need to create a new one.
from react-awesome-shapes.
@ashutosh1919, sure. will continue to work on the same PR.
from react-awesome-shapes.
@Sachin-chaurasiya , yes I have used it to adjust values corresponding to the breakpoint. Still, it is not the best solution. Sure, I am assigning this issue to you. You may want to approach solution like this (IMO): remove entire usage of media query. instead, find the value to use for this particular screen size. solution should be pure JS. Then, we can eleminate react-responsive
.
from react-awesome-shapes.
@ashutosh1919, sure would love to work on it.
but for now, can we go with this approach? let me know what are your thoughts.
from react-awesome-shapes.
Not happening anymore so closing it.
Feel free to open it if the issue still persists.
from react-awesome-shapes.
Related Issues (20)
- Star Shape HOT 1
- Create seperate folder for constants HOT 2
- Getting overflow scroll on some contents of the page HOT 1
- Cross Shape HOT 1
- Refactor folder structure and rename some files.
- Heart Shape HOT 3
- Left arrow , Right arrow, Square Frame(like donut) and few more shapes! HOT 1
- Pass props to animate the shapes HOT 3
- Remove Triangle, Square and Hexagon HOT 4
- Square Frame like Donut! HOT 3
- Arrow shape
- Add CI to check for linting issues.
- Code CleanUp and Refactoring HOT 1
- Remove react-responsive HOT 1
- Move out all the typescript types in single file. HOT 2
- Message Shape HOT 3
- Add Unit Tests for components HOT 4
- onHover the square background appears to change color HOT 2
- Is it possible to add text inside the shapes? HOT 1
- Requires an old version of Node HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-awesome-shapes.