Bug in random-max-percent calculation about kube-monkey HOT 6 CLOSED

@gzlatkov Thanks for catching this. This does seem like a bug. A PR would be really appreciated.

A couple of thoughts:

1. Instead of math.Round(), lets do math.Floor() instead so we never over-kill pods. So, with n=3 and killValue=50, we should never kill 2 pods.
2. I'm not sure what the best way to get the number of pods in chaos.go is. That info isn't already available there, so it will likely need to be added to the Victim interface so each victim can report the number of pods.

cc @Spellchaser

from kube-monkey.

Hey @asobti,

1. That sounds reasonable!
2. I think we do have that information as it is extracted from the clientset which we are already have in func (c *Chaos) terminate(clientset kube.Interface) error. Will try to test that tomorrow.

from kube-monkey.

Hey @gzlatkov . Just checking in to see if you had a chance to work on this bug.

from kube-monkey.

Hi @asobti. I was looking into adding a fixed percentage mode when I came across this same issue.
I raised a pr with the my proposal for a new kill mode which includes a fix for this bug: #94

from kube-monkey.

@asobti Sorry, got caught up in work and was on holiday. My stuff still need the unittest adjustments, so I'm happy to go over @worldtiki's PR, which seems to be expanding on the fix with a new termination mode.

from kube-monkey.

Fixed by #94

from kube-monkey.