Comments (14)
Very sorry for my inattention.
I did not notice that you are the author of the tool.
:)
Sorry one more time...
And thank for the tool!
from add-trailing-comma.
One more example
bankrupts = [{
'id': company.bankrupt_id,
'type': 'company',
} for company in found_companies]
This shouldn't be rewritten with:
bankrupts = [
{
'id': company.bankrupt_id,
'type': 'company',
} for company in found_companies
]
from add-trailing-comma.
Should or shouldn't? The second is consistent with the style.
from add-trailing-comma.
The first is also consistent with the style.
And therefore shouldn't be rewritten.
from add-trailing-comma.
It is not, the style prescribes no hugging braces (unless on a line with only braces)
from add-trailing-comma.
sadly...
from add-trailing-comma.
No not sadly, that's how this tool is designed. If you don't like that style, don't use the tool! 😆
This issue is about making more constructs get rewritten in that way
from add-trailing-comma.
This tool is very useful
So it is sadly :)
Because I really find this style useful:
async def test_ambiguous(api_request):
response = await api_request('some_method', some_param='some-value')
assert response['error'] == {
'code': 6001,
'message': 'Validation error',
'data': {'errors': [
{'code': 'ambiguous', 'message': 'Ambiguous'},
]}
}
I don't want to expand this line 'data': {'errors': [
because it has no "semantic value".
from add-trailing-comma.
Tough! The tool can't possibly determine """semantic value"""
I don't know what to tell you
from add-trailing-comma.
oops...
This case works fine for me
async def test_ambiguous(api_request):
response = await api_request('some_method', some_param='some-value')
assert response['error'] == {
'code': 6001,
'message': 'Validation error',
'data': {'errors': [
{'code': 'ambiguous', 'message': 'Ambiguous'},
]}
}
add-trailing-comma doesn't touch it!
Problem is only with this
bankrupts = [{
'id': company.bankrupt_id,
'type': 'company',
} for company in found_companies]
from add-trailing-comma.
Look, I think you're missing the point. The whole goal of the tool is so you don't argue about style.
from add-trailing-comma.
The tool just shouldn't touch this case
bankrupts = [{
'id': company.bankrupt_id,
'type': 'company',
} for company in found_companies]
And also shouldn't touch this case too
bankrupts = [
{
'id': company.bankrupt_id,
'type': 'company',
} for company in found_companies
]
They are both valid
A person can choose according to "semantic value" or some other "magic" he likes
from add-trailing-comma.
I'm sorry, the first one is ugly and will continue to be rewritten. Please stop
from add-trailing-comma.
PyCharm Reformat Code works exactly that way i want
https://www.jetbrains.com/help/pycharm/reformatting-source-code.html
Please stop
ok
from add-trailing-comma.
Related Issues (20)
- Do not add trailing comma on single parameter function calls HOT 2
- Configure with pyproject.toml HOT 3
- `AssertionError: Past end?` on match statement HOT 2
- `AssertionError: Past end?` on match statement class with no args HOT 1
- Using pre-commit hook in combination with yapf HOT 2
- Enable the `directory` args option in addition to `filenames` HOT 3
- Dict trailing comma HOT 2
- Document compatibility with isort HOT 1
- Add support for Jupyter notebooks? HOT 2
- An option to disable de-indent of braces HOT 1
- add trailing commas in PEP 695 type aliases
- How to manually apply for a folder on windows? HOT 1
- Possible to ignore files (e.g., with glob pattern)? HOT 1
- Readme still references `--py35-plus/--py36-plus`
- Would you be interested in PRs making add-trailing commas more configurable? HOT 1
- Question: is there a way to not add comma in a multiline string? HOT 3
- needs a readme update HOT 1
- Provide a Docker image HOT 3
- escaped brackets in f-string are not parsed properly for python 3.12 HOT 1
- Fail when run together with autopep8 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from add-trailing-comma.