Giter VIP home page Giter VIP logo

Comments (10)

asottile avatar asottile commented on June 2, 2024 1

see now you're bikeshedding the style

from reorder-python-imports.

tolomea avatar tolomea commented on June 2, 2024

I should add that I'm happy to have a crack at a PR, just given the history I'd like to check first if it's going to get a flat no response. And if not how you feel about the optional vs always question.

from reorder-python-imports.

asottile avatar asottile commented on June 2, 2024

no thanks -- the whole point of the tool is there's no bikeshedding. it does one thing and only one thing. isort for example has a fractal of options which makes it impossible to agree on a style

from reorder-python-imports.

tolomea avatar tolomea commented on June 2, 2024

ok, but what about as unconditional, which would be my suggested option anyway.

from reorder-python-imports.

tolomea avatar tolomea commented on June 2, 2024

I strongly agree with limited options, I like black for that as well.

from reorder-python-imports.

asottile avatar asottile commented on June 2, 2024

it already is unconditional?

from reorder-python-imports.

tolomea avatar tolomea commented on June 2, 2024

I mean always sort relative imports after absolute ones. Don't provide an option, change the opinionated style.

from reorder-python-imports.

tolomea avatar tolomea commented on June 2, 2024

Within the existing blocks, so just a couple of lines change to each of the sort_key functions. The number field at the front that's used for distinguishing from imports could be extended to have a couple more values for relative and from relative.

from reorder-python-imports.

tolomea avatar tolomea commented on June 2, 2024

A new value for relative, there isn't a import .bob, clearly time for me to go home for the evening.

from reorder-python-imports.

tolomea avatar tolomea commented on June 2, 2024

I viewed it as suggesting an improvement to a bit of the style that afaik you don't personally care about.

from reorder-python-imports.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.