Comments (12)
This looks like another ASP.NET breaking change, I'll fix it. I'm working on getting the dev
and rel/...
branches added to our CI so I can be notified about these things
If you want something stable, I'd recommend the rel/2.0.0-preview1
branch which uses a fixed set of ASP.NET libraries and the latest dotnet
CLI/SDK/Runtime
from jitbench.
Looks like I missed the change to MusicStoreContext
in aspnet/MusicStore@6c13465
I looked over this commit when I saw it get merged to the MusicStore repo, and didn't catch this in with all of the changes that aren't relevant to JitBench.
from jitbench.
It sounds like you will be checking a fix for this shortly.
I rather continue working in the Dev branch as I need to collect profile data to use with future versions.
from jitbench.
rel/2.0.0-preview1
works with the latest dotnet versions, do you mean you're tracking the ASP.NET changes specifically?
from jitbench.
Fixed here: 9404090
from jitbench.
@rynowak Reopen
Github has very simple rights/privileges (and even simpler management for them).
If you are not a collaborator of a repo, then (in regards to issues)
you can open issues
you can comment on all existing issues (open or closed)
you can close your own issues
you can re-open your own issues *if you closed them yourself
you cannot close or re-open issues opened by someone else
you cannot re-open your own issues if a repo collaborator closed them
from jitbench.
??? Are you saying this is still broken?
This is passing on travis and appveyor
https://travis-ci.org/aspnet/JitBench/builds/238178713
https://ci.appveyor.com/project/aspnetci/jitbench/build/1.0.71
from jitbench.
Yes, I was still getting those same two errors when building in the dev branch.
I sounded like you checked on something to the wrong branch and then reverted it.
from jitbench.
I checked it in to master and then reverted it there because master tracks 2.0.0-preview1.
The commit in dev is this one 9404090
from jitbench.
If you're still having trouble I can stop by and take a look. This is working for me and in on the CIs.
from jitbench.
OK It is fixed, I had a local change that was prevent me from pulling down your fix.
from jitbench.
OK good, glad we got to the bottom of this.
from jitbench.
Related Issues (20)
- A new database warning HOT 1
- A new database issue on appveyor HOT 2
- Update dotnet-install scripts HOT 1
- Remove set +e from scripts that get sourced HOT 1
- dotnet store fails with error that it cannot find DiaSymReader HOT 1
- Cannot find framework... HOT 1
- Enable CI HOT 1
- All branches currently broken HOT 4
- dotnet publish failing for 2.0 x86 HOT 14
- Announcement: rel/2.0.0-preview2 available HOT 1
- Announcement: Precompilation was on by default
- JitBench dev branch not using master branch builds of CoreCLR HOT 5
- Known Issue: Unable to resolve path for 'coreclr' HOT 2
- Announcement: Updating to netcoreapp2.1 HOT 1
- Discussion: Using custom crossgen for JitBench HOT 7
- Dev branch README instructions currently don't seem to get latest CoreCLR bits HOT 14
- MusicStore fails with System.Net.Http.HttpRequestException error HOT 6
- Support latest 3.0 preview HOT 4
- Announcment: Updating to 3.0 and simplifying scripts
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jitbench.