Dev branch build is broken about jitbench HOT 12 CLOSED

This looks like another ASP.NET breaking change, I'll fix it. I'm working on getting the dev and rel/... branches added to our CI so I can be notified about these things

If you want something stable, I'd recommend the rel/2.0.0-preview1 branch which uses a fixed set of ASP.NET libraries and the latest dotnet CLI/SDK/Runtime

from jitbench.

Looks like I missed the change to MusicStoreContext in aspnet/MusicStore@6c13465

I looked over this commit when I saw it get merged to the MusicStore repo, and didn't catch this in with all of the changes that aren't relevant to JitBench.

from jitbench.

It sounds like you will be checking a fix for this shortly.
I rather continue working in the Dev branch as I need to collect profile data to use with future versions.

from jitbench.

rel/2.0.0-preview1 works with the latest dotnet versions, do you mean you're tracking the ASP.NET changes specifically?

from jitbench.

Fixed here: 9404090

from jitbench.

@rynowak Reopen

Github has very simple rights/privileges (and even simpler management for them).

If you are not a collaborator of a repo, then (in regards to issues)

you can open issues
you can comment on all existing issues (open or closed)
you can close your own issues
you can re-open your own issues *if you closed them yourself
you cannot close or re-open issues opened by someone else
you cannot re-open your own issues if a repo collaborator closed them

from jitbench.

??? Are you saying this is still broken?

This is passing on travis and appveyor
https://travis-ci.org/aspnet/JitBench/builds/238178713
https://ci.appveyor.com/project/aspnetci/jitbench/build/1.0.71

from jitbench.

Yes, I was still getting those same two errors when building in the dev branch.
I sounded like you checked on something to the wrong branch and then reverted it.

from jitbench.

I checked it in to master and then reverted it there because master tracks 2.0.0-preview1.

The commit in dev is this one 9404090

from jitbench.

If you're still having trouble I can stop by and take a look. This is working for me and in on the CIs.

from jitbench.

OK It is fixed, I had a local change that was prevent me from pulling down your fix.

from jitbench.

OK good, glad we got to the bottom of this.

from jitbench.