Giter VIP home page Giter VIP logo

Comments (7)

joel-costigliola avatar joel-costigliola commented on July 23, 2024

Assertions is generated in the most basic package, i.e. c.b.a.e package since it contains less package than c.b.a.c.i.

Can you tell me what is broken ?

from assertj-assertions-generator-maven-plugin.

Kwaq avatar Kwaq commented on July 23, 2024

Assertions class is being moved after adding

<class>c.b.a.e.AnotherClass</class>

Existing tests which are using c.b.a.c.i.Assertions are not compiling anymore.

from assertj-assertions-generator-maven-plugin.

joel-costigliola avatar joel-costigliola commented on July 23, 2024

The simplest solution is to get rid of c.b.a.c.i.Assertions and use c.b.a.e.Assertions.

We could add a configuration option to set where Assertions class will be generated but if you haven't set this option at your first run your problem will still be there as the plugin will have to to generate Assertions somewhere.

WDYT ?

from assertj-assertions-generator-maven-plugin.

Kwaq avatar Kwaq commented on July 23, 2024

The option is good idea.

Also, I found out, that generator is generating Javadoc comments, that are causing Javadoc generation failure.

Creates a new </code>{@link SomeObjectAssert}</code> to make assertions on actual SomeObject.

As you can see there are two closing tags which are making Javadoc generator unhappy.

Should I post issue about this?

from assertj-assertions-generator-maven-plugin.

joel-costigliola avatar joel-costigliola commented on July 23, 2024

No, I'm gonna create the issue and fix it right away, thanks

from assertj-assertions-generator-maven-plugin.

floppywaste avatar floppywaste commented on July 23, 2024

Hi,

I saw too late that you were already going to address this issue. I needed the fix and have just made a modification that adds an optional package name under which the entry point class will be generated. You might want to check out my fork at https://github.com/floppywaste/assertj-assertions-generator-maven-plugin and https://github.com/floppywaste/assertj-assertions-generator

It's tested and works fine for me.

from assertj-assertions-generator-maven-plugin.

joel-costigliola avatar joel-costigliola commented on July 23, 2024

I have integrated your solution, thanks.

from assertj-assertions-generator-maven-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.