Giter VIP home page Giter VIP logo

Comments (5)

kimkulling avatar kimkulling commented on June 12, 2024 1

Hi, would be great if you could prepare a PR for this issue.

Thanks!

from assimp.

stephengold avatar stephengold commented on June 12, 2024

Address sanitizer output is available from #5438

from assimp.

stephengold avatar stephengold commented on June 12, 2024

Correction: the crash does not occur during post-processing. It occurs while calculating the scene's memory usage.

assimp/code/Common/Importer.cpp

Line 1268 in ff5b0ae

for (unsigned int i = 0; i < mScene->mNumMaterials;++i) {

Using GDB, I set a breakpoint at code/Common/Importer.cpp line 1268, and saw that mScene->mNumMaterials is 1. I believe it should've been set to zero in RemoveRedundantMatsProcess::Execute().

Stepping through RemoveRedundantMatsProcess::Execute(), I see it return from line 161:

assimp/code/PostProcessing/RemoveRedundantMaterials.cpp

Lines 159 to 162 in ff5b0ae

if (iNewNum < 1) {
//throw DeadlyImportError("No materials remaining");
return;
}

At that point, mMaterials[0] has been set to nullptr, but mNumMaterials has not been updated---it is still 1. That explains the segmentation violation.

from assimp.

stephengold avatar stephengold commented on June 12, 2024

I could easily write a PR to solve this issue, but after what happened with #5438 I've decided to wait for an explicit PR request and not submit unsolicited code.

from assimp.

stephengold avatar stephengold commented on June 12, 2024

Since #5467 is integrated, I believe this issue is solved and can be closed.

from assimp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.