Giter VIP home page Giter VIP logo

Comments (12)

hadim avatar hadim commented on May 29, 2024

Not that I also use svg {height: 100%;} in my css.

from decktape.

hadim avatar hadim commented on May 29, 2024

In fact viewBox is used but it seems that width and height attributes of the SVG file are used in priority over the viewBox because when I remove the SVG attributes width and height then the SVG is correctly rendered as in browser.

Any idea to make it a permanent fix ? Should I open an issue for phantomjs ?

from decktape.

astefanutti avatar astefanutti commented on May 29, 2024

A suggested in #4, that may be better to directly report this point in Qt issue tracker directly:

https://bugreports.qt.io/browse/QTBUG

from decktape.

hadim avatar hadim commented on May 29, 2024

Removing width and height attributes does not work well. Qt Webkit needs to be fixed. I filled an issue there : https://bugreports.qt.io/browse/QTBUG-46986

from decktape.

hadim avatar hadim commented on May 29, 2024

@astefanutti I'd like to test it with Qt 5.5. Is the best way replace phantomjs/src/qt source code with Qt 5.5 ? Nothing more to do ?

from decktape.

astefanutti avatar astefanutti commented on May 29, 2024

Sounds like a good idea. You can replace the phantomjs/src/qt. An other approach would be to apply the diff between 5.4.1 and 5.5.0.

There may be some PhantomJS build resources to update like:
ariya/phantomjs@68ca7c3#diff-d6d9dd3e06474412f0bb613c0b88248bR2

Let me know how it goes.

from decktape.

hadim avatar hadim commented on May 29, 2024

Well since Qt example browser give the same result as with phantomjs/decktape I won't bother switch phantomjs to 5.5. Instead I will build qt 5.5 from source with browser example and do the test from the browser example.

from decktape.

astefanutti avatar astefanutti commented on May 29, 2024

Great idea, that'd be much easier.

from decktape.

hadim avatar hadim commented on May 29, 2024

I confirm the bug is still present in 5.5.1, tested with examples/webkitwidgets/browser.

from decktape.

astefanutti avatar astefanutti commented on May 29, 2024

OK, thanks for head up.

from decktape.

hadim avatar hadim commented on May 29, 2024

The issue does not appear using QtWebEngine (tested with examples/webengine/quicknanobrowser/quicknanobrowser). And after reading some posts about QtWebKit/QtWebEngine, I saw that QtWebKit is not supported anymore... So I guess the best is to wait PhantomJS to move to QtWebEngine as they said there : ariya/phantomjs#12931

from decktape.

hadim avatar hadim commented on May 29, 2024

I close since it depends on QtWebkit.

from decktape.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.