`cl-letf` warning about buffer-env HOT 9 CLOSED

The macro cl-left is auto-loaded, so this might actually be a Flymake issue?

from buffer-env.

Beside some typo fixes, I see no major changes in recent Flymake commits though.

from buffer-env.

The information for Emacs Lisp's Flymake backend comes from the byte compiler, so it might be that the byte-compiler was recently made more strict. Either way, your suggestion to require cl-lib at compile-time if a cl-lib macro is being used is correct. Augusto has to decide if it is worth complicating the README for this sake...

from buffer-env.

Well, this is confusing. If the macro is autoloaded (as emacs -Q tells me it is), then we shouldn't need the require, right? If this changed recently, it's bound to break other things as well...

from buffer-env.

Well, this is confusing. If the macro is autoloaded (as emacs -Q tells me it is), then we shouldn't need the require, right? If this changed recently, it's bound to break other things as well...

Do you want me to file a bug on the Emacs tracker referencing this ticket?

from buffer-env.

Do you want me to file a bug on the Emacs tracker referencing this ticket?

Probably. I did some tests locally. If I evaluate say

(cl-letf (((default-value 'process-environment) nil)))

on a fresh emacs -Q, then I get an error the first time, and then in a second attempt it works — probably because cl-lib got loaded in the process of displaying the error message. So maybe the reason why you started to get this error is because you removed something from your config that used to load cl-lib as a side-effect?

from buffer-env.

So maybe the reason why you started to get this error is because you removed something from your config that used to load cl-lib as a side-effect?

It could very well be, but I have to track down what I removed. Also, the question remains: should it be autoloaded? If so, do we need to report this as a bug?

from buffer-env.

This may turn out to have some reasonable explanation and not to be a bug, but to me the fact that cl-letf is an autoloaded macro should mean you can pretend it's always available to use. So if you want to report a bug I think it would be nice!

from buffer-env.

Here we go: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59714 :)

from buffer-env.