Giter VIP home page Giter VIP logo

Comments (2)

fjebaker avatar fjebaker commented on June 12, 2024 1

I am able to reproduce. These sorts of precision errors in the root finder normally mean the extrema of the bracketing interval which sets up the precision tracer missed the disc. This often happens when roughly $r_\text{e} \geq \frac{1}{2} r_\text{d}$.

A simple fix is to set, e.g.

d = GeometricThinDisc(0.0, 800.0, π / 2)

But I'll leave this issue open with the addition that

  • This should either generate a more friendly error message; or
  • Use a better heuristic when calculating the bracketing intervals for continuous discs / find appropriate behaviour when the disc is sparse.

For the latter, the offending line is

which could probably be safely set to d.outer_radius + Δ, where Δ is just a safety offset. In the past this had to scale to help the root finder converge, but we're using a better default algorithm now, so we might be able to get away with just using the same maximum offset for each emission radius.

from gradus.jl.

fjebaker avatar fjebaker commented on June 12, 2024

Fixed in #107

from gradus.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.